Fix build failures caused by rclc macro name change - #36
Merged
Conversation
micro-ROS/rclc@8ae0747 changed the name of the UNUSED macro to RCLC_UNUSED. This broke the build for two examples. Signed-off-by: Robert Wilbrandt <robert@stamm-wilbrandt.de>
AndyBlightLeeds
approved these changes
Nov 2, 2020
AndyBlightLeeds
left a comment
AndyBlightLeeds
left a comment
There was a problem hiding this comment.
I found the same problem today. Changes look good.
JanStaschulat
approved these changes
Nov 2, 2020
JanStaschulat
left a comment
JanStaschulat
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the PR.
Member
|
Thank you all for the report and fix! |
This was referenced Nov 3, 2020
fofolevrai
pushed a commit
to fofolevrai/freertos_apps
that referenced
this pull request
Jun 14, 2021
* Modified approach to build system * Crazyflie + FreeRTOS package * Host Package * Nuttx + Olimex e407 package * Build system fixes * Updated readme * config package names to lowercase * typo * Added fast build options * Updated to dashing * Creating CF firm updates to dashing repos * Fix Crystal to Dashing in Readme * Fix Crystal to Dashing deps in nuttx olimex * CF21 build and create script updates * Typo * Hotfix * Firmware host applications working * Hotfix * Updated CF firm repo to upstream * Meta update * Installing version of arm-gcc locally * Update repo to dashing * Remove debug from build * Added compatible CF firm commit * Updated rcutils repo * Updated metas for new rcutils approach * Updated metas * Update metas and CF build * Downloading message * Update MicroXRCEDDS and MicroCDR versions * Typos * Update micro-ROS agent version updates * Fix * Refactor build and create scripts Unified common parts to generalize scripts * Added example_interfaces for services demos * Added MicroXRCE build parameters * Fix create and build scripts * Dependency management using rosdep * Fix file location * Nuttx configuration using scripts parameters * Typo * Repos * Updated merge install in CF * RMW configuration new approach * Updated max history * MicroXRCEDDS isolated install and version update * Updated target branch Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
micro-ROS/rclc@8ae0747 changed the name
of the UNUSED macro to RCLC_UNUSED. This broke the build for two
examples.
Signed-off-by: Robert Wilbrandt robert@stamm-wilbrandt.de