Skip to content

Commit fbc4945

Browse files
committed
normalize memory-quota error contains assertions
1 parent fe32c5c commit fbc4945

1 file changed

Lines changed: 10 additions & 30 deletions

File tree

vibes/memory_quota_test.go

Lines changed: 10 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -307,9 +307,7 @@ func TestTransientExpressionAllocationsAreChecked(t *testing.T) {
307307
if err == nil {
308308
t.Fatalf("expected memory quota error for transient expression allocation")
309309
}
310-
if !strings.Contains(err.Error(), "memory quota exceeded") {
311-
t.Fatalf("unexpected error: %v", err)
312-
}
310+
requireErrorContains(t, err, "memory quota exceeded")
313311
}
314312

315313
func TestIndexedTransientAllocationsAreChecked(t *testing.T) {
@@ -363,9 +361,7 @@ func TestIndexedTransientAllocationsAreChecked(t *testing.T) {
363361
if err == nil {
364362
t.Fatalf("expected memory quota error for indexed transient allocation")
365363
}
366-
if !strings.Contains(err.Error(), "memory quota exceeded") {
367-
t.Fatalf("unexpected error: %v", err)
368-
}
364+
requireErrorContains(t, err, "memory quota exceeded")
369365
}
370366

371367
func TestTransientMethodCallReceiverAllocationsAreChecked(t *testing.T) {
@@ -422,9 +418,7 @@ func TestTransientMethodCallReceiverAllocationsAreChecked(t *testing.T) {
422418
if err == nil {
423419
t.Fatalf("expected memory quota error for transient method-call receiver allocation")
424420
}
425-
if !strings.Contains(err.Error(), "memory quota exceeded") {
426-
t.Fatalf("unexpected error: %v", err)
427-
}
421+
requireErrorContains(t, err, "memory quota exceeded")
428422
}
429423

430424
func TestIfConditionTransientAllocationsAreChecked(t *testing.T) {
@@ -480,9 +474,7 @@ func TestIfConditionTransientAllocationsAreChecked(t *testing.T) {
480474
if err == nil {
481475
t.Fatalf("expected memory quota error for if-condition transient allocation")
482476
}
483-
if !strings.Contains(err.Error(), "memory quota exceeded") {
484-
t.Fatalf("unexpected error: %v", err)
485-
}
477+
requireErrorContains(t, err, "memory quota exceeded")
486478
}
487479

488480
func TestAggregateBuiltinArgumentsAreChecked(t *testing.T) {
@@ -541,9 +533,7 @@ func TestAggregateBuiltinArgumentsAreChecked(t *testing.T) {
541533
if err == nil {
542534
t.Fatalf("expected memory quota error for aggregate builtin arguments")
543535
}
544-
if !strings.Contains(err.Error(), "memory quota exceeded") {
545-
t.Fatalf("unexpected error: %v", err)
546-
}
536+
requireErrorContains(t, err, "memory quota exceeded")
547537
}
548538

549539
func TestTransientAssignmentValueIsCheckedBeforeAssign(t *testing.T) {
@@ -612,9 +602,7 @@ func TestTransientAssignmentValueIsCheckedBeforeAssign(t *testing.T) {
612602
if err == nil {
613603
t.Fatalf("expected memory quota error for transient assignment value")
614604
}
615-
if !strings.Contains(err.Error(), "memory quota exceeded") {
616-
t.Fatalf("unexpected error: %v", err)
617-
}
605+
requireErrorContains(t, err, "memory quota exceeded")
618606
}
619607

620608
func TestTransientUnaryOperandAllocationsAreChecked(t *testing.T) {
@@ -668,9 +656,7 @@ func TestTransientUnaryOperandAllocationsAreChecked(t *testing.T) {
668656
if err == nil {
669657
t.Fatalf("expected memory quota error for unary transient operand")
670658
}
671-
if !strings.Contains(err.Error(), "memory quota exceeded") {
672-
t.Fatalf("unexpected error: %v", err)
673-
}
659+
requireErrorContains(t, err, "memory quota exceeded")
674660
}
675661

676662
func TestTransientBinaryOperandsAreChecked(t *testing.T) {
@@ -725,9 +711,7 @@ func TestTransientBinaryOperandsAreChecked(t *testing.T) {
725711
if err == nil {
726712
t.Fatalf("expected memory quota error for binary transient operands")
727713
}
728-
if !strings.Contains(err.Error(), "memory quota exceeded") {
729-
t.Fatalf("unexpected error: %v", err)
730-
}
714+
requireErrorContains(t, err, "memory quota exceeded")
731715
}
732716

733717
func TestAssignmentTargetExpressionsAreChecked(t *testing.T) {
@@ -789,9 +773,7 @@ func TestAssignmentTargetExpressionsAreChecked(t *testing.T) {
789773
if err == nil {
790774
t.Fatalf("expected memory quota error for assignment target transient allocation")
791775
}
792-
if !strings.Contains(err.Error(), "memory quota exceeded") {
793-
t.Fatalf("unexpected error: %v", err)
794-
}
776+
requireErrorContains(t, err, "memory quota exceeded")
795777
}
796778

797779
func TestAggregateYieldArgumentsAreChecked(t *testing.T) {
@@ -851,7 +833,5 @@ func TestAggregateYieldArgumentsAreChecked(t *testing.T) {
851833
if err == nil {
852834
t.Fatalf("expected memory quota error for aggregate yield arguments")
853835
}
854-
if !strings.Contains(err.Error(), "memory quota exceeded") {
855-
t.Fatalf("unexpected error: %v", err)
856-
}
836+
requireErrorContains(t, err, "memory quota exceeded")
857837
}

0 commit comments

Comments
 (0)