Require integer random_id lengths

Author: mgomes

vibes/builtins.go

@@ -115,11 +115,10 @@ func builtinRandomID(exec *Execution, receiver Value, args []Value, kwargs map[s
 		return NewNil(), fmt.Errorf("random_id expects at most one length argument")
 	}
 	if len(args) == 1 {
-		n, err := valueToInt64(args[0])
-		if err != nil {
+		if args[0].Kind() != KindInt {
 			return NewNil(), fmt.Errorf("random_id length must be integer")
 		}
-		length = n
+		length = args[0].Int()
 	}
 	if length <= 0 {
 		return NewNil(), fmt.Errorf("random_id length must be positive")

vibes/runtime_test.go

@@ -2070,13 +2070,17 @@ func TestRandomIdentifierBuiltins(t *testing.T) {
       }
     end
 
-    def bad_length_type()
-      random_id("x")
-    end
+	    def bad_length_type()
+	      random_id("x")
+	    end
 
-    def bad_length_value()
-      random_id(0)
-    end
+	    def bad_length_float()
+	      random_id(8.9)
+	    end
+
+	    def bad_length_value()
+	      random_id(0)
+	    end
 
     def bad_uuid_args()
       uuid(1)
@@ -2107,6 +2111,9 @@ func TestRandomIdentifierBuiltins(t *testing.T) {
 	if _, err := script.Call(context.Background(), "bad_length_type", nil, CallOptions{}); err == nil || !strings.Contains(err.Error(), "random_id length must be integer") {
 		t.Fatalf("expected length type error, got %v", err)
 	}
+	if _, err := script.Call(context.Background(), "bad_length_float", nil, CallOptions{}); err == nil || !strings.Contains(err.Error(), "random_id length must be integer") {
+		t.Fatalf("expected length float error, got %v", err)
+	}
 	if _, err := script.Call(context.Background(), "bad_length_value", nil, CallOptions{}); err == nil || !strings.Contains(err.Error(), "random_id length must be positive") {
 		t.Fatalf("expected length value error, got %v", err)
 	}