restore fail-fast memory checks across call argument evaluation

Author: mgomes

vibes/execution_call_expr.go

@@ -66,6 +66,9 @@ func (exec *Execution) evalCallArgs(call *CallExpr, env *Env) ([]Value, error) {
 		if err != nil {
 			return nil, err
 		}
+		if err := exec.checkMemoryWith(val); err != nil {
+			return nil, err
+		}
 		args[i] = val
 	}
 	return args, nil
@@ -81,6 +84,9 @@ func (exec *Execution) evalCallKwArgs(call *CallExpr, env *Env) (map[string]Valu
 		if err != nil {
 			return nil, err
 		}
+		if err := exec.checkMemoryWith(val); err != nil {
+			return nil, err
+		}
 		kwargs[kw.Name] = val
 	}
 	return kwargs, nil
@@ -90,7 +96,14 @@ func (exec *Execution) evalCallBlock(call *CallExpr, env *Env) (Value, error) {
 	if call.Block == nil {
 		return NewNil(), nil
 	}
-	return exec.evalBlockLiteral(call.Block, env)
+	block, err := exec.evalBlockLiteral(call.Block, env)
+	if err != nil {
+		return NewNil(), err
+	}
+	if err := exec.checkMemoryWith(block); err != nil {
+		return NewNil(), err
+	}
+	return block, nil
 }
 
 func (exec *Execution) checkCallMemoryRoots(receiver Value, args []Value, kwargs map[string]Value, block Value) error {

vibes/memory_quota_test.go

@@ -568,6 +568,50 @@ func TestAggregateBuiltinArgumentsAreChecked(t *testing.T) {
 	requireErrorContains(t, err, "memory quota exceeded")
 }
 
+func TestCallArgumentMemoryChecksFailFastBeforeLaterSideEffects(t *testing.T) {
+	pos := Position{Line: 1, Column: 1}
+	payload := strings.Repeat("a", 5000)
+	tickCount := 0
+
+	stmt := &ExprStmt{
+		Expr: &CallExpr{
+			Callee: &Identifier{Name: "noop", position: pos},
+			Args: []Expression{
+				&StringLiteral{Value: payload, position: pos},
+				&CallExpr{
+					Callee:   &Identifier{Name: "tick", position: pos},
+					position: pos,
+				},
+			},
+			position: pos,
+		},
+		position: pos,
+	}
+
+	exec := &Execution{
+		quota:         10000,
+		memoryQuota:   2048,
+		moduleLoading: make(map[string]bool),
+	}
+	env := newEnv(nil)
+	env.Define("noop", NewBuiltin("noop", func(exec *Execution, receiver Value, args []Value, kwargs map[string]Value, block Value) (Value, error) {
+		return NewNil(), nil
+	}))
+	env.Define("tick", NewBuiltin("tick", func(exec *Execution, receiver Value, args []Value, kwargs map[string]Value, block Value) (Value, error) {
+		tickCount++
+		return NewInt(1), nil
+	}))
+
+	_, _, err := exec.evalStatements([]Statement{stmt}, env)
+	if err == nil {
+		t.Fatalf("expected memory quota error for oversized first argument")
+	}
+	requireErrorContains(t, err, "memory quota exceeded")
+	if tickCount != 0 {
+		t.Fatalf("expected later argument side effects to be skipped, got %d", tickCount)
+	}
+}
+
 func TestTransientAssignmentValueIsCheckedBeforeAssign(t *testing.T) {
 	pos := Position{Line: 1, Column: 1}
 	elements := make([]Expression, 1200)