reuse shared error assertion helper in capability constructor tests

Author: mgomes

vibes/capability_context_test.go

@@ -2,7 +2,6 @@ package vibes
 
 import (
 	"context"
-	"strings"
 	"testing"
 )
 
@@ -91,10 +90,9 @@ end`)
 func TestNewContextCapabilityRejectsInvalidArguments(t *testing.T) {
 	resolver := func(context.Context) (Value, error) { return NewObject(map[string]Value{}), nil }
 
-	if _, err := NewContextCapability("", resolver); err == nil || !strings.Contains(err.Error(), "name must be non-empty") {
-		t.Fatalf("expected empty name error, got %v", err)
-	}
-	if _, err := NewContextCapability("ctx", nil); err == nil || !strings.Contains(err.Error(), "requires a resolver") {
-		t.Fatalf("expected nil resolver error, got %v", err)
-	}
+	_, err := NewContextCapability("", resolver)
+	requireErrorContains(t, err, "name must be non-empty")
+
+	_, err = NewContextCapability("ctx", nil)
+	requireErrorContains(t, err, "requires a resolver")
 }

vibes/capability_db_test.go

@@ -2,7 +2,6 @@ package vibes
 
 import (
 	"context"
-	"strings"
 	"testing"
 )
 
@@ -306,17 +305,14 @@ end`)
 func TestNewDBCapabilityRejectsInvalidArguments(t *testing.T) {
 	stub := &dbCapabilityStub{}
 
-	if _, err := NewDBCapability("", stub); err == nil || !strings.Contains(err.Error(), "name must be non-empty") {
-		t.Fatalf("expected empty name error, got %v", err)
-	}
+	_, err := NewDBCapability("", stub)
+	requireErrorContains(t, err, "name must be non-empty")
 
 	var db Database
-	if _, err := NewDBCapability("db", db); err == nil || !strings.Contains(err.Error(), "requires a non-nil implementation") {
-		t.Fatalf("expected nil db error, got %v", err)
-	}
+	_, err = NewDBCapability("db", db)
+	requireErrorContains(t, err, "requires a non-nil implementation")
 
 	var typedNil *dbCapabilityStub
-	if _, err := NewDBCapability("db", typedNil); err == nil || !strings.Contains(err.Error(), "requires a non-nil implementation") {
-		t.Fatalf("expected typed nil db error, got %v", err)
-	}
+	_, err = NewDBCapability("db", typedNil)
+	requireErrorContains(t, err, "requires a non-nil implementation")
 }

vibes/capability_events_test.go

@@ -2,7 +2,6 @@ package vibes
 
 import (
 	"context"
-	"strings"
 	"testing"
 )
 
@@ -125,17 +124,14 @@ end`)
 
 func TestNewEventsCapabilityRejectsInvalidArguments(t *testing.T) {
 	stub := &eventsCapabilityStub{}
-	if _, err := NewEventsCapability("", stub); err == nil || !strings.Contains(err.Error(), "name must be non-empty") {
-		t.Fatalf("expected empty name error, got %v", err)
-	}
+	_, err := NewEventsCapability("", stub)
+	requireErrorContains(t, err, "name must be non-empty")
 
 	var publisher EventPublisher
-	if _, err := NewEventsCapability("events", publisher); err == nil || !strings.Contains(err.Error(), "requires a non-nil implementation") {
-		t.Fatalf("expected nil publisher error, got %v", err)
-	}
+	_, err = NewEventsCapability("events", publisher)
+	requireErrorContains(t, err, "requires a non-nil implementation")
 
 	var typedNil *eventsCapabilityStub
-	if _, err := NewEventsCapability("events", typedNil); err == nil || !strings.Contains(err.Error(), "requires a non-nil implementation") {
-		t.Fatalf("expected typed nil publisher error, got %v", err)
-	}
+	_, err = NewEventsCapability("events", typedNil)
+	requireErrorContains(t, err, "requires a non-nil implementation")
 }