Advance past zero-width replace_all matches

Author: mgomes

vibes/builtins.go

@@ -516,18 +516,18 @@ func regexReplaceAllWithLimit(re *regexp.Regexp, text string, replacement string
 		}
 		lastAppended = loc[1]
 
-		if loc[1] > searchStart {
+		if loc[1] > loc[0] {
 			searchStart = loc[1]
 			continue
 		}
-		if searchStart >= len(text) {
+		if loc[1] >= len(text) {
 			break
 		}
-		_, size := utf8.DecodeRuneInString(text[searchStart:])
+		_, size := utf8.DecodeRuneInString(text[loc[1]:])
 		if size == 0 {
 			size = 1
 		}
-		searchStart += size
+		searchStart = loc[1] + size
 	}
 
 	tailLen := len(text) - lastAppended

vibes/runtime_test.go

@@ -1955,6 +1955,7 @@ func TestRegexBuiltins(t *testing.T) {
 	        replace_one: Regex.replace("ID-12 ID-34", "ID-[0-9]+", "X"),
 	        replace_all: Regex.replace_all("ID-12 ID-34", "ID-[0-9]+", "X"),
 	        replace_all_anchor: Regex.replace_all("abc", "^", "X"),
+	        replace_all_boundary: Regex.replace_all("ab", "\\b", "X"),
 	        replace_capture: Regex.replace("ID-12 ID-34", "ID-([0-9]+)", "X-$1"),
 	        replace_boundary: Regex.replace("ab", "\\Bb", "X")
 	      }
@@ -1988,6 +1989,9 @@ func TestRegexBuiltins(t *testing.T) {
 	if !out["replace_all_anchor"].Equal(NewString("Xabc")) {
 		t.Fatalf("replace_all_anchor mismatch: %v", out["replace_all_anchor"])
 	}
+	if !out["replace_all_boundary"].Equal(NewString("XabX")) {
+		t.Fatalf("replace_all_boundary mismatch: %v", out["replace_all_boundary"])
+	}
 	if !out["replace_capture"].Equal(NewString("X-12 ID-34")) {
 		t.Fatalf("replace_capture mismatch: %v", out["replace_capture"])
 	}