Use Meziantou.DotNet.CodingStandard (#660)

Author: meziantou

.editorconfig

@@ -34,7 +34,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="DotNet.ReproducibleBuilds" Version="1.1.1">
+    <PackageReference Include="Meziantou.DotNet.CodingStandard" Version="1.0.96">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>

Directory.Build.props

@@ -1,6 +1,4 @@
-#pragma warning disable CA1812
-#pragma warning disable CA1852
-using System.IO.Compression;
+using System.IO.Compression;
 using System.Reflection;
 using System.Reflection.Metadata;
 using System.Reflection.PortableExecutable;
@@ -15,13 +13,13 @@
     "Microsoft.WindowsDesktop.App.Ref", // https://www.nuget.org/packages/Microsoft.WindowsDesktop.App.Ref
 };
 
-var cache = new SourceCacheContext();
+using var cache = new SourceCacheContext();
 var repository = Repository.Factory.GetCoreV3("https://api.nuget.org/v3/index.json");
 var resource = await repository.GetResourceAsync<FindPackageByIdResource>();
 
 foreach (var includePreview in new[] { false, true })
 {
-    var types = new HashSet<string>();
+    var types = new HashSet<string>(StringComparer.Ordinal);
     foreach (var packageName in packages)
     {
         var versions = await resource.GetAllVersionsAsync(packageName, cache, NullLogger.Instance, CancellationToken.None);
@@ -58,7 +56,7 @@
         }
     }
 
-    await File.WriteAllLinesAsync(Path.Combine(args.Length > 0 ? args[0] : "../../../../Meziantou.Analyzer/Resources/", includePreview ? "bcl-preview.txt" : "bcl.txt"), types.OrderBy(t => t));
+    await File.WriteAllLinesAsync(Path.Combine(args.Length > 0 ? args[0] : "../../../../Meziantou.Analyzer/Resources/", includePreview ? "bcl-preview.txt" : "bcl.txt"), types.OrderBy(t => t, StringComparer.Ordinal));
 }
 
 static MemoryStream CopyToMemoryStream(ZipArchiveEntry entry)

src/DocumentationGenerator/.editorconfig

@@ -0,0 +1,18 @@
+#pragma warning disable CS1591
+#pragma warning disable IDE0060
+#pragma warning disable CA1019
+#nullable disable
+
+namespace Meziantou.Analyzer.Annotations;
+
+/// <summary>
+/// Indicates arguments must be named for this parameter.
+/// </summary>
+[System.Diagnostics.Conditional("MEZIANTOU_ANALYZER_ANNOTATIONS")]
+[System.AttributeUsage(System.AttributeTargets.Parameter)]
+public sealed class RequireNamedArgumentAttribute : System.Attribute
+{
+    public RequireNamedArgumentAttribute() { }
+
+    public RequireNamedArgumentAttribute(bool isRequired) { }
+}

src/DocumentationGenerator/Program.cs

@@ -0,0 +1,14 @@
+#pragma warning disable CS1591
+#pragma warning disable IDE0060
+#pragma warning disable IDE0290
+#pragma warning disable CA1019
+#nullable disable
+
+namespace Meziantou.Analyzer.Annotations;
+
+[System.Diagnostics.Conditional("MEZIANTOU_ANALYZER_ANNOTATIONS")]
+[System.AttributeUsage(System.AttributeTargets.Assembly, AllowMultiple = true, Inherited = false)]
+public sealed class StructuredLogFieldAttribute : System.Attribute
+{
+    public StructuredLogFieldAttribute(string parameterName, params System.Type[] allowedTypes) { }
+}

src/ListDotNetTypes/Program.cs

@@ -63,7 +63,7 @@ private async Task<Document> GetDocumentFixesAsync(FixAllContext fixAllContext)
         }
 
         var newRoot = await FixAllInDocumentAsync(fixAllContext, document, diagnostics).ConfigureAwait(false);
-        if (newRoot == null)
+        if (newRoot is null)
         {
             return document;
         }
@@ -91,7 +91,7 @@ private async Task<Solution> GetSolutionFixesAsync(FixAllContext fixAllContext,
         for (var i = 0; i < documents.Length; i++)
         {
             var newDocumentRoot = await newDocuments[i].ConfigureAwait(false);
-            if (newDocumentRoot == null)
+            if (newDocumentRoot is null)
                 continue;
 
             solution = solution.WithDocumentSyntaxRoot(documents[i].Id, newDocumentRoot);

src/Meziantou.Analyzer.Annotations/Annotations.cs

@@ -26,7 +26,7 @@ public static async Task<ImmutableDictionary<Document, ImmutableArray<Diagnostic
         switch (fixAllContext.Scope)
         {
             case FixAllScope.Document:
-                if (document != null)
+                if (document is not null)
                 {
                     var documentDiagnostics = await fixAllContext.GetDocumentDiagnosticsAsync(document).ConfigureAwait(false);
                     return ImmutableDictionary<Document, ImmutableArray<Diagnostic>>.Empty.SetItem(document, documentDiagnostics);
@@ -96,7 +96,7 @@ private static async Task<ImmutableDictionary<Document, ImmutableArray<Diagnosti
         {
             cancellationToken.ThrowIfCancellationRequested();
             var document = documentAndDiagnostics.Key;
-            if (document != null)
+            if (document is not null)
             {
                 var diagnosticsForDocument = documentAndDiagnostics.ToImmutableArray();
                 builder.Add(document, diagnosticsForDocument);
@@ -116,7 +116,7 @@ private static async Task<ImmutableDictionary<SyntaxTree, Document>> GetTreeToDo
             {
                 cancellationToken.ThrowIfCancellationRequested();
                 var tree = await document.GetSyntaxTreeAsync(cancellationToken).ConfigureAwait(false);
-                if (tree != null)
+                if (tree is not null)
                 {
                     builder.Add(tree, document);
                 }
@@ -129,7 +129,7 @@ private static async Task<ImmutableDictionary<SyntaxTree, Document>> GetTreeToDo
     private static Document? GetReportedDocument(Diagnostic diagnostic, ImmutableDictionary<SyntaxTree, Document> treeToDocumentsMap)
     {
         var tree = diagnostic.Location.SourceTree;
-        if (tree != null)
+        if (tree is not null)
         {
             if (treeToDocumentsMap.TryGetValue(tree, out var document))
             {