fix(jewels): Add compareJewelsOfSameType option for ItemsTab

Port of bugfix/compare-jewels-same-type-empty-socket onto current
origin/dev. Adapted to upstream PathOfBuildingCommunity#9744 changes (new sort-based
addCompareForSlot structure): filter moved inside addCompareForSlot
so it applies to all codepaths (slotOnlyTooltips, limited uniques,
and sorted comparison loop).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: mcagnion

src/Classes/ItemsTab.lua

@@ -4139,6 +4139,9 @@ function ItemsTabClass:AddItemTooltip(tooltip, item, slot, dbMode, maxWidth)
 			if not selItem or not output then
 				selItem, output = getReplacedItemAndOutput(compareSlot)
 			end
+			if main.compareJewelsOfSameType and item.type == "Jewel" and selItem and not self:IsSameJewelComparisonType(item, selItem) then
+				return
+			end
 			local header
 			if item == selItem then
 				header = "^7Removing this item from "..compareSlot.label.." will give you:"
@@ -4236,6 +4239,22 @@ function ItemsTabClass:AddItemTooltip(tooltip, item, slot, dbMode, maxWidth)
 	end
 end
 
+function ItemsTabClass:IsSameJewelComparisonType(firstItem, secondItem)
+	if not secondItem then
+		return false
+	end
+	if firstItem.type ~= "Jewel" or secondItem.type ~= "Jewel" then
+		return false
+	end
+
+	if not firstItem.base or not secondItem.base then
+		return firstItem.type == secondItem.type
+	end
+
+	return firstItem.base.type == secondItem.base.type
+		and firstItem.base.subType == secondItem.base.subType
+end
+
 function ItemsTabClass:CreateUndoState()
 	local state = { }
 	state.activeItemSetId = self.activeItemSetId

src/Modules/Main.lua

@@ -119,6 +119,7 @@ function main:Init()
 	self.showFlavourText = true
 	self.showAnimations = true
 	self.showAllItemAffixes = true
+	self.compareJewelsOfSameType = false
 	self.errorReadingSettings = false
 
 	if not SetDPIScaleOverridePercent then SetDPIScaleOverridePercent = function(scale) end end
@@ -630,6 +631,9 @@ function main:LoadSettings(ignoreBuild)
 					self.dpiScaleOverridePercent = tonumber(node.attrib.dpiScaleOverridePercent) or 0
 					SetDPIScaleOverridePercent(self.dpiScaleOverridePercent)
 				end
+				if node.attrib.compareJewelsOfSameType then
+					self.compareJewelsOfSameType = node.attrib.compareJewelsOfSameType == "true"
+				end
 			end
 		end
 	end
@@ -762,6 +766,7 @@ function main:SaveSettings()
 		showAnimations = tostring(self.showAnimations),
 		showAllItemAffixes = tostring(self.showAllItemAffixes),
 		dpiScaleOverridePercent = tostring(self.dpiScaleOverridePercent),
+		compareJewelsOfSameType = tostring(self.compareJewelsOfSameType),
 	} })
 	local res, errMsg = common.xml.SaveXMLFile(setXML, self.userPath.."Settings.xml")
 	if not res then
@@ -845,11 +850,12 @@ function main:OpenOptionsPopup(savedState)
 		showFlavourText = self.showFlavourText,
 		showAnimations = self.showAnimations,
 		showAllItemAffixes = self.showAllItemAffixes,
-		dpiScaleOverridePercent = self.dpiScaleOverridePercent
+		dpiScaleOverridePercent = self.dpiScaleOverridePercent,
+		compareJewelsOfSameType = self.compareJewelsOfSameType
 	}
 
 	-- NOTE: Height needs to be adjusted if more menu options are added
-	local oneColumnHeightReq = 850 -- Min height required to not split menu into two columns
+	local oneColumnHeightReq = 876 -- Min height required to not split menu into two columns
 	local columnWidth = 600
 
 	local startingY = 20
@@ -1114,7 +1120,14 @@ function main:OpenOptionsPopup(savedState)
 	end)
 	controls.invertSliderScrollDirection.tooltipText = "Default scroll direction is:\nScroll Up = Move right\nScroll Down = Move left"
 	controls.invertSliderScrollDirection.state = self.invertSliderScrollDirection
-	
+
+	nextRow()
+	controls.compareJewelsOfSameType = new("CheckBoxControl", { "TOPLEFT", controls.sectionAnchor, "TOPLEFT" }, { currentX + defaultLabelPlacementX, currentY, 20 }, "^7Compare jewels by type only:", function(state)
+		self.compareJewelsOfSameType = state
+	end)
+	controls.compareJewelsOfSameType.tooltipText = "Only compare jewels against equipped jewels of the same base type. Empty jewel sockets are still shown."
+	controls.compareJewelsOfSameType.state = self.compareJewelsOfSameType
+
 	if launch.devMode then
 		nextRow()
 		controls.disableDevAutoSave = new("CheckBoxControl", { "TOPLEFT", controls.sectionAnchor, "TOPLEFT" }, { currentX + defaultLabelPlacementX, currentY, 20 }, "^7Disable Dev AutoSave:", function(state)
@@ -1193,6 +1206,7 @@ function main:OpenOptionsPopup(savedState)
 		self.showAllItemAffixes = savedState.showAllItemAffixes
 		self.dpiScaleOverridePercent = savedState.dpiScaleOverridePercent
 		SetDPIScaleOverridePercent(self.dpiScaleOverridePercent)
+		self.compareJewelsOfSameType = savedState.compareJewelsOfSameType
 		main:ClosePopup()
 	end)