Use old-style null validation

Author: maxkoshevoi

src/libraries/Microsoft.Extensions.Options/src/ValidateOptions.cs

@@ -17,8 +17,13 @@ public class ValidateOptions<TOptions> : IValidateOptions<TOptions> where TOptio
         /// <param name="name">Options name.</param>
         /// <param name="validation">Validation function.</param>
         /// <param name="failureMessage">Validation failure message.</param>
-        public ValidateOptions(string? name, Func<TOptions, bool> validation!!, string failureMessage)
+        public ValidateOptions(string? name, Func<TOptions, bool> validation, string failureMessage)
         {
+            if (validation == null)
+            {
+                throw new ArgumentNullException(nameof(validation));
+            }
+
             Name = name;
             Validation = validation;
             FailureMessage = failureMessage;
@@ -76,8 +81,13 @@ public class ValidateOptions<TOptions, TDep> : IValidateOptions<TOptions> where
         /// <param name="dependency">The dependency.</param>
         /// <param name="validation">Validation function.</param>
         /// <param name="failureMessage">Validation failure message.</param>
-        public ValidateOptions(string? name, TDep dependency, Func<TOptions, TDep, bool> validation!!, string failureMessage)
+        public ValidateOptions(string? name, TDep dependency, Func<TOptions, TDep, bool> validation, string failureMessage)
         {
+            if (validation == null)
+            {
+                throw new ArgumentNullException(nameof(validation));
+            }
+
             Name = name;
             Validation = validation;
             FailureMessage = failureMessage;
@@ -143,8 +153,13 @@ public class ValidateOptions<TOptions, TDep1, TDep2> : IValidateOptions<TOptions
         /// <param name="dependency2">The second dependency.</param>
         /// <param name="validation">Validation function.</param>
         /// <param name="failureMessage">Validation failure message.</param>
-        public ValidateOptions(string? name, TDep1 dependency1, TDep2 dependency2, Func<TOptions, TDep1, TDep2, bool> validation!!, string failureMessage)
+        public ValidateOptions(string? name, TDep1 dependency1, TDep2 dependency2, Func<TOptions, TDep1, TDep2, bool> validation, string failureMessage)
         {
+            if (validation == null)
+            {
+                throw new ArgumentNullException(nameof(validation));
+            }
+
             Name = name;
             Validation = validation;
             FailureMessage = failureMessage;
@@ -218,8 +233,13 @@ public class ValidateOptions<TOptions, TDep1, TDep2, TDep3> : IValidateOptions<T
         /// <param name="dependency3">The third dependency.</param>
         /// <param name="validation">Validation function.</param>
         /// <param name="failureMessage">Validation failure message.</param>
-        public ValidateOptions(string? name, TDep1 dependency1, TDep2 dependency2, TDep3 dependency3, Func<TOptions, TDep1, TDep2, TDep3, bool> validation!!, string failureMessage)
+        public ValidateOptions(string? name, TDep1 dependency1, TDep2 dependency2, TDep3 dependency3, Func<TOptions, TDep1, TDep2, TDep3, bool> validation, string failureMessage)
         {
+            if (validation == null)
+            {
+                throw new ArgumentNullException(nameof(validation));
+            }
+
             Name = name;
             Validation = validation;
             FailureMessage = failureMessage;
@@ -301,8 +321,13 @@ public class ValidateOptions<TOptions, TDep1, TDep2, TDep3, TDep4> : IValidateOp
         /// <param name="dependency4">The fourth dependency.</param>
         /// <param name="validation">Validation function.</param>
         /// <param name="failureMessage">Validation failure message.</param>
-        public ValidateOptions(string? name, TDep1 dependency1, TDep2 dependency2, TDep3 dependency3, TDep4 dependency4, Func<TOptions, TDep1, TDep2, TDep3, TDep4, bool> validation!!, string failureMessage)
+        public ValidateOptions(string? name, TDep1 dependency1, TDep2 dependency2, TDep3 dependency3, TDep4 dependency4, Func<TOptions, TDep1, TDep2, TDep3, TDep4, bool> validation, string failureMessage)
         {
+            if (validation == null)
+            {
+                throw new ArgumentNullException(nameof(validation));
+            }
+
             Name = name;
             Validation = validation;
             FailureMessage = failureMessage;
@@ -392,8 +417,12 @@ public class ValidateOptions<TOptions, TDep1, TDep2, TDep3, TDep4, TDep5> : IVal
         /// <param name="dependency5">The fifth dependency.</param>
         /// <param name="validation">Validation function.</param>
         /// <param name="failureMessage">Validation failure message.</param>
-        public ValidateOptions(string? name, TDep1 dependency1, TDep2 dependency2, TDep3 dependency3, TDep4 dependency4, TDep5 dependency5, Func<TOptions, TDep1, TDep2, TDep3, TDep4, TDep5, bool> validation!!, string failureMessage)
+        public ValidateOptions(string? name, TDep1 dependency1, TDep2 dependency2, TDep3 dependency3, TDep4 dependency4, TDep5 dependency5, Func<TOptions, TDep1, TDep2, TDep3, TDep4, TDep5, bool> validation, string failureMessage)
         {
+            if (validation == null)
+            {
+                throw new ArgumentNullException(nameof(validation));
+            }
             Name = name;
             Validation = validation;
             FailureMessage = failureMessage;