add island labels (#399, #646, #703) - #737
Conversation
|
@zerebubuth This is still a WIP, but it's pretty close to done. Please have a look around, particularly at migration and query parts. I've verified the zooms are working well in the DB for the test cases, but still need to fully run the test via python. |
|
Also connects to #703 to move the continent label placement from |
|
Also connects to #646 to move the last layer, |
| max(gid) AS __id__ | ||
| max(gid) AS __id__, | ||
| NULL AS label_placement, | ||
| NULL AS boundary |
There was a problem hiding this comment.
I think we prefer to do the addition of extra parameters (label_placement, boundary) via YAML now, to avoid having to do NULL AS ... in the other queries.
There was a problem hiding this comment.
Good point, I'll revise.
(This is loosely based off the water.jinja2 file, probably similar cleanup over there, but I'd rather not mess with that in this PR.)
d8cba1a to
5c11337
Compare
…ing islands, islets & etc
c698f2e to
6a01957
Compare
… show as early as zoom 7
|
I've got it all working (!?) except for these handful of tests which fail:
Similar test do pass, though, and the features exist in the DB and seem to be marked with the expected zoom values. The Because I'll be traveling the rest of the week, please pick up this PR and see it to completion. Thanks! |
…don't have it. Include all earth features at z16.
|
Tests pass for me. I think all the issues above should be fixed now. @rmarianski could you review this, please? |
|
👍 |
Connects with #399 to add island, islet & other labels. Also refactors how the earth layer is constructed.