Skip to content

Commit e45cafa

Browse files
committed
fix: address.family is number in Node v18
See nodejs/node#41431 Signed-off-by: Francisco Buceta <frbuceta@gmail.com>
1 parent ff8cbff commit e45cafa

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

packages/http-server/src/__tests__/integration/http-server.integration.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ describe('HttpServer (integration)', () => {
2929
host: '::1',
3030
} as HttpOptions);
3131
await server.start();
32-
expect(getAddressFamily(server)).to.equal('IPv6');
32+
expect(getAddressFamily(server)).to.equalOneOf(6, 'IPv6');
3333
const response = await httpGetAsync(server.url);
3434
expect(response.statusCode).to.equal(200);
3535
});
@@ -225,15 +225,15 @@ describe('HttpServer (integration)', () => {
225225
it('supports HTTP over IPv4', async () => {
226226
server = new HttpServer(dummyRequestHandler, {host: '127.0.0.1'});
227227
await server.start();
228-
expect(getAddressFamily(server)).to.equal('IPv4');
228+
expect(getAddressFamily(server)).to.equalOneOf(4, 'IPv4');
229229
const response = await httpGetAsync(server.url);
230230
expect(response.statusCode).to.equal(200);
231231
});
232232

233233
skipOnTravis(it, 'supports HTTP over IPv6', async () => {
234234
server = new HttpServer(dummyRequestHandler, {host: '::1'});
235235
await server.start();
236-
expect(getAddressFamily(server)).to.equal('IPv6');
236+
expect(getAddressFamily(server)).to.equalOneOf(6, 'IPv6');
237237
const response = await httpGetAsync(server.url);
238238
expect(response.statusCode).to.equal(200);
239239
});
@@ -258,7 +258,7 @@ describe('HttpServer (integration)', () => {
258258
host: '::1',
259259
});
260260
await httpsServer.start();
261-
expect(getAddressFamily(httpsServer)).to.equal('IPv6');
261+
expect(getAddressFamily(httpsServer)).to.equalOneOf(6, 'IPv6');
262262
const response = await httpsGetAsync(httpsServer.url);
263263
expect(response.statusCode).to.equal(200);
264264
});

packages/http-server/src/http-server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ export class HttpServer {
231231
return `${this.protocol}+unix://${basePath}`;
232232
}
233233
let host = this.host;
234-
if (this._address.family === 'IPv6') {
234+
if ([6, 'IPv6'].includes(this._address.family)) {
235235
if (host === '::') host = '::1';
236236
host = `[${host}]`;
237237
} else if (host === '0.0.0.0') {

0 commit comments

Comments
 (0)