Skip to content

Commit 8845446

Browse files
Shyam Sundar S Kgregkh
authored andcommitted
net: amd-xgbe: Fix network fluctuations when using 1G BELFUSE SFP
[ Upstream commit 9eab3fd ] Frequent link up/down events can happen when a Bel Fuse SFP part is connected to the amd-xgbe device. Try to avoid the frequent link issues by resetting the PHY as documented in Bel Fuse SFP datasheets. Fixes: e722ec8 ("amd-xgbe: Update the BelFuse quirk to support SGMII") Co-developed-by: Sudheesh Mavila <sudheesh.mavila@amd.com> Signed-off-by: Sudheesh Mavila <sudheesh.mavila@amd.com> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> Acked-by: Tom Lendacky <thomas.lendacky@amd.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 286fca3 commit 8845446

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -922,6 +922,9 @@ static bool xgbe_phy_belfuse_phy_quirks(struct xgbe_prv_data *pdata)
922922
if ((phy_id & 0xfffffff0) != 0x03625d10)
923923
return false;
924924

925+
/* Reset PHY - wait for self-clearing reset bit to clear */
926+
genphy_soft_reset(phy_data->phydev);
927+
925928
/* Disable RGMII mode */
926929
phy_write(phy_data->phydev, 0x18, 0x7007);
927930
reg = phy_read(phy_data->phydev, 0x18);

0 commit comments

Comments
 (0)