Skip to content

Commit 2643680

Browse files
authored
Rename packages to use underscores. (#58)
The latest Linebender standard is to name packages with an underscore instead of a dash. Historically we used dashes, but later migrated to underscores. One of the main motivators being that then the package name matches how it is imported in code (always underscore). This wasn't well documented on the Linebender website, which I [just recently fixed](https://linebender.org/wiki/naming-scheme/). Also, just taking a peek at the [Vello](https://github.com/linebender/vello) or [Xilem](https://github.com/linebender/xilem) repos will show packages like `vello_hybrid` and `xilem_masonry`. Because packages can't be renamed after publishing (`pkg_name` and `pkg-name` are considered identical by crates.io) it's important to get this renaming done before we publish. In addition to changing the dashes to underscores, I also changed the `kompari_cli` output binary name to just `kompari` as that seems far nicer to me than either `kompari-cli` or `kompari_cli`. Also, this binary name can be easily changed later if we want to.
1 parent f252694 commit 2643680

21 files changed

Lines changed: 337 additions & 419 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ env:
1010
# the Unreleased section of CHANGELOG.md, plus all the README.md files of the affected packages.
1111
RUST_MIN_VER: "1.85"
1212
# List of packages that can not target Wasm.
13-
NO_WASM_PKGS: "--exclude kompari-cli --exclude kompari-html --exclude kompari-tasks"
13+
NO_WASM_PKGS: "--exclude kompari_cli --exclude kompari_html --exclude kompari_tasks"
1414
# List of packages that will be checked with the minimum supported Rust version.
1515
# This should be limited to packages that are intended for publishing.
16-
RUST_MIN_VER_PKGS: "-p kompari -p kompari-html -p kompari-tasks"
16+
RUST_MIN_VER_PKGS: "-p kompari -p kompari_cli -p kompari_html -p kompari_tasks"
1717
# Whether the workspace contains Rust code using the debug_assertions configuration option.
1818
USING_DEBUG_ASSERTIONS: "false"
1919

Cargo.lock

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[workspace]
22
resolver = "2"
3-
members = ["kompari", "kompari-cli", "kompari-html", "kompari-tasks"]
3+
members = ["kompari", "kompari_cli", "kompari_html", "kompari_tasks"]
44

55
[workspace.package]
66
version = "0.1.0"
@@ -13,8 +13,8 @@ repository = "https://github.com/linebender/kompari"
1313

1414
[workspace.dependencies]
1515
kompari = { version = "0.1.0", path = "kompari", default-features = false }
16-
kompari-html = { version = "0.1.0", path = "kompari-html", default-features = false }
17-
kompari-tasks = { version = "0.1.0", path = "kompari-tasks", default-features = false }
16+
kompari_html = { version = "0.1.0", path = "kompari_html", default-features = false }
17+
kompari_tasks = { version = "0.1.0", path = "kompari_tasks", default-features = false }
1818

1919
assert_cmd = "2.2.0"
2020
axum = "0.8.9"

0 commit comments

Comments
 (0)