fix(connection-manager): address review feedback on per-address timeout

- Fix JSDoc @see URL to point to public ConnectionManagerInit interface
  instead of internal ConnectionManagerConfig

- Replace timing-based assertion in the sequential-hang test with a
  signal-based one: listen for abort on each hung dial's options.signal
  and count aborts. Verifies the per-address AbortSignal was actually
  fired three times rather than measuring wall-clock elapsed time, which
  is flaky on loaded CI runners.

Author: paschal533

packages/libp2p/src/connection-manager/constants.defaults.ts

@@ -4,7 +4,7 @@
 export const DIAL_TIMEOUT = 10_000
 
 /**
- * @see https://libp2p.github.io/js-libp2p/interfaces/index._internal_.ConnectionManagerConfig.html#addressDialTimeout
+ * @see https://libp2p.github.io/js-libp2p/interfaces/libp2p.index.ConnectionManagerInit.html#addressDialTimeout
  */
 export const ADDRESS_DIAL_TIMEOUT = 6_000
 

packages/libp2p/test/connection-manager/dial-queue.spec.ts

@@ -482,6 +482,7 @@ describe('dial queue', () => {
       const connection = stubInterface<Connection>()
       const addressDialTimeout = 100
       const dialledAddrs: string[] = []
+      let dialsAborted = 0
 
       components.transportManager.dialTransportForMultiaddr.returns(stubInterface<Transport>())
       components.transportManager.dial.callsFake(async (ma, options) => {
@@ -490,6 +491,7 @@ describe('dial queue', () => {
 
         if (!maStr.includes('1234')) {
           // first three addresses hang – will be cut by per-address timeout
+          options?.signal?.addEventListener('abort', () => { dialsAborted++ }, { once: true })
           return hangUntilAborted(options)
         }
 
@@ -501,14 +503,12 @@ describe('dial queue', () => {
         dialTimeout: 10_000
       })
 
-      const start = Date.now()
       const conn = await dialer.dial([
         multiaddr('/ip4/127.0.0.1/tcp/1231'),
         multiaddr('/ip4/127.0.0.1/tcp/1232'),
         multiaddr('/ip4/127.0.0.1/tcp/1233'),
         multiaddr('/ip4/127.0.0.1/tcp/1234')
       ])
-      const elapsed = Date.now() - start
 
       expect(conn).to.equal(connection)
       // all four addresses were attempted in order
@@ -518,9 +518,8 @@ describe('dial queue', () => {
         '/ip4/127.0.0.1/tcp/1233',
         '/ip4/127.0.0.1/tcp/1234'
       ])
-      // elapsed ~= 3 × addressDialTimeout (three per-address timeouts before success)
-      expect(elapsed).to.be.greaterThan(addressDialTimeout * 2)
-      expect(elapsed).to.be.lessThan(addressDialTimeout * 6)
+      // per-address signal was aborted for each of the three hung dials
+      expect(dialsAborted).to.equal(3)
     })
 
     it('should throw an AggregateError when every address times out per-address before the batch timeout', async () => {