Merge pull request #508 from dleehr/fix-push-progressblock

Fix bug where GTPushTransferProgressBlock is unused

Author: joshaber

ObjectiveGit/GTRepository+RemoteOperations.m

@@ -219,7 +219,7 @@ - (BOOL)pushRefspecs:(NSArray *)refspecs toRemote:(GTRemote *)remote withOptions
 
 	git_remote_callbacks remote_callbacks = GIT_REMOTE_CALLBACKS_INIT;
 	remote_callbacks.credentials = (credProvider != nil ? GTCredentialAcquireCallback : NULL),
-	remote_callbacks.transfer_progress = GTRemoteFetchTransferProgressCallback,
+	remote_callbacks.push_transfer_progress = GTRemotePushTransferProgressCallback;
 	remote_callbacks.payload = &connectionInfo,
 
 	gitError = git_remote_connect(remote.git_remote, GIT_DIRECTION_PUSH, &remote_callbacks);
@@ -239,6 +239,8 @@ - (BOOL)pushRefspecs:(NSArray *)refspecs toRemote:(GTRemote *)remote withOptions
 		return NO;
 	}
 
+	push_options.callbacks = remote_callbacks;
+
 	const git_strarray git_refspecs = refspecs.git_strarray;
 
 	gitError = git_remote_upload(remote.git_remote, &git_refspecs, &push_options);

ObjectiveGitTests/GTRemotePushSpec.m

@@ -115,7 +115,7 @@
 				}];
 				expect(error).to(beNil());
 				expect(@(result)).to(beTruthy());
-				expect(@(transferProgressed)).to(beFalsy()); // Local transport doesn't currently call progress callbacks
+				expect(@(transferProgressed)).to(beTruthy());
 
 				// Same number of commits after push, refresh branch first
 				remoteMasterBranch = localBranchWithName(@"master", remoteRepo);
@@ -152,7 +152,7 @@
 			}];
 			expect(error).to(beNil());
 			expect(@(result)).to(beTruthy());
-			expect(@(transferProgressed)).to(beFalsy()); // Local transport doesn't currently call progress callbacks
+			expect(@(transferProgressed)).to(beTruthy());
 
 			// Number of commits on tracking branch after push
 			localTrackingBranch = [masterBranch trackingBranchWithError:&error success:&success];