Fix mangled non-ASCII module specifiers (#569)

Author: maksimyaromin

src/module/module_handle.cc

@@ -89,7 +89,7 @@ auto ModuleHandle::GetDependencySpecifiers() -> Local<Value> {
 	size_t length = info->dependency_specifiers.size();
 	Local<Array> deps = Array::New(isolate, length);
 	for (size_t ii = 0; ii < length; ++ii) {
-		Unmaybe(deps->Set(isolate->GetCurrentContext(), ii, v8_string(info->dependency_specifiers[ii].c_str())));
+		Unmaybe(deps->Set(isolate->GetCurrentContext(), ii, HandleCast<Local<String>>(info->dependency_specifiers[ii])));
 	}
 	return deps;
 }
@@ -308,7 +308,7 @@ class ModuleLinker : public ClassHandle {
 			argv[1] = module->This();
 			Local<Function> fn = callback.Deref();
 			for (size_t ii = 0; ii < info->dependency_specifiers.size(); ++ii) {
-				argv[0] = v8_string(info->dependency_specifiers[ii].c_str());
+				argv[0] = HandleCast<Local<String>>(info->dependency_specifiers[ii]);
 				impl->HandleCallbackReturn(module, ii, Unmaybe(fn->Call(context, recv, 2, argv)));
 			}
 		}

tests/module-specifier-utf8.js

@@ -0,0 +1,20 @@
+const ivm = require('isolated-vm');
+const { strictEqual } = require('assert');
+
+(async function() {
+	const isolate = new ivm.Isolate();
+	const context = await isolate.createContext();
+	const specifier = './café-中-😀.js';
+	const root = await isolate.compileModule(`import value from '${specifier}'; globalThis.value = value;`);
+	const dependency = await isolate.compileModule('export default 42;');
+
+	strictEqual(root.dependencySpecifiers[0], specifier);
+	await root.instantiate(context, received => {
+		strictEqual(received, specifier);
+		return dependency;
+	});
+	await root.evaluate();
+	strictEqual(await context.global.get('value'), 42);
+
+	console.log('pass');
+})().catch(err => { console.error(err); });