fix(fireworks): require api_key in FireworksEmbeddings (#37193)

Author: mdrxy

libs/partners/fireworks/langchain_fireworks/chat_models.py

@@ -708,11 +708,7 @@ def validate_environment(self) -> Self:
             raise ValueError(msg)
 
         client_params = {
-            "api_key": (
-                self.fireworks_api_key.get_secret_value()
-                if self.fireworks_api_key
-                else None
-            ),
+            "api_key": self.fireworks_api_key.get_secret_value(),
             "base_url": self.fireworks_api_base,
             "timeout": self.request_timeout,
         }

libs/partners/fireworks/langchain_fireworks/embeddings.py

@@ -71,7 +71,11 @@ class FireworksEmbeddings(BaseModel, Embeddings):
         alias="api_key",
         default_factory=secret_from_env(
             "FIREWORKS_API_KEY",
-            default="",
+            error_message=(
+                "You must specify an api key. "
+                "You can pass it an argument as `api_key=...` or "
+                "set the environment variable `FIREWORKS_API_KEY`."
+            ),
         ),
     )
     """Fireworks API key.

libs/partners/fireworks/tests/unit_tests/test_embeddings.py

@@ -1,8 +1,13 @@
 """Test embedding model integration."""
 
+from pydantic import SecretStr
+
 from langchain_fireworks.embeddings import FireworksEmbeddings
 
 
 def test_initialization() -> None:
     """Test embedding model initialization."""
-    FireworksEmbeddings(model="nomic-ai/nomic-embed-text-v1.5")
+    FireworksEmbeddings(
+        model="nomic-ai/nomic-embed-text-v1.5",
+        api_key=SecretStr("test_api_key"),
+    )

libs/partners/fireworks/tests/unit_tests/test_embeddings_standard.py

@@ -2,6 +2,7 @@
 
 from langchain_core.embeddings import Embeddings
 from langchain_tests.unit_tests.embeddings import EmbeddingsUnitTests
+from pydantic import SecretStr
 
 from langchain_fireworks import FireworksEmbeddings
 
@@ -12,8 +13,8 @@ def embeddings_class(self) -> type[Embeddings]:
         return FireworksEmbeddings
 
     @property
-    def embeddings_params(self) -> dict:
-        return {"api_key": "test_api_key"}
+    def embedding_model_params(self) -> dict:
+        return {"api_key": SecretStr("test_api_key")}
 
     @property
     def init_from_env_params(self) -> tuple[dict, dict, dict]: