Fix some linter issues - #40
Merged
Merged
Conversation
Collaborator
|
Could we possibly add tests for this thing? |
Author
Ok, if you run the spec only with the first commit (Add a test with a block route) you get this error: If you run the spec on the second commit (Skip empty tags and fix routes without a Rails controller) it will produce an OpenAPI YAML with an empty summary. I removed the last commit (When a route is not found print a warning in place of an exception) to make some extra checks. |
blocknotes
marked this pull request as ready for review
March 18, 2022 21:58
added 3 commits
March 18, 2022 23:00
Fix linter error: Operation object `summary` must be non-empty string. 9 | "/api/v1/posts": 10 | get: 11 | summary: '' 12 | tags: 13 | - Error was generated by the operation-summary rule.
k0kubun
approved these changes
Mar 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey :)
Checking with
@redocly/openapi-clilinter I get some errors:Expected type string but got nullrelated to thetagskey when an empty value is exported;Operation object summary must be non-empty string.related to thesummarykey when an empty value is exported.This PR is a proposal for minor improvements.
Please let me know your opinion.