Skip to content

Generate headers and servers block - #30

Merged
k0kubun merged 3 commits into
exoego:masterfrom
Cado-Labs:check-authorize-header
Aug 23, 2021
Merged

Generate headers and servers block#30
k0kubun merged 3 commits into
exoego:masterfrom
Cado-Labs:check-authorize-header

Conversation

@AS-AlStar

Copy link
Copy Markdown
Contributor

Added generating parameters on the file for required specific headers.
Added generating block with servers on the file .

@k0kubun

k0kubun commented Aug 21, 2021

Copy link
Copy Markdown
Collaborator

Could you make tests pass first?

@AS-AlStar

Copy link
Copy Markdown
Contributor Author

Ok, please, approve running workflows.

@k0kubun k0kubun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k0kubun
k0kubun merged commit cb634d0 into exoego:master Aug 23, 2021
@k0kubun

k0kubun commented Aug 23, 2021

Copy link
Copy Markdown
Collaborator

Oh actually, before releasing this, may I confirm whether you intended to use the headers config for response headers as well or not? If you are only interested in documenting request headers using this feature, can we rename the config to request_headers so that we can separately have response_headers?

@AS-AlStar

AS-AlStar commented Aug 26, 2021

Copy link
Copy Markdown
Contributor Author

I use only for request headers. Yes, you are right, let's rename to request_headers. Should I create a new pull request or will you fix it yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants