Handle schema errors without failing the build - #27
Merged
Conversation
k0kubun
reviewed
Jun 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Don't crash the build :) Skip bad records.
One of our requests raises "NotImplementedError: type detection is not implemented for: #<JSONAPI::Exceptions::BadRequest: JSONAPI::Exceptions::BadRequest>>" which causes the whole build to fail.
The specific error is " request_params={"_parser_exception"=>#<JSONAPI::Exceptions::BadRequest: JSONAPI::Exceptions::BadRequest>},"
I was thinking it would be nice to use objects here instead of block scope, but that's for another day.
For example, then I could more easily write my own hook logic that didn't rely on the
example.metadata[:type] == :request