Skip to content

Commit 46d488f

Browse files
authored
ci: pin nyc in node@8 and skip node@9 (#49)
PR-URL: #49 REF: #48 and jshttp/http-errors#109
1 parent c94df7d commit 46d488f

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ jobs:
2222
- Node.js 7.x
2323
- Node.js 8.0 # test early async_hooks
2424
- Node.js 8.x
25+
# test fail on Node.js 9.x for unknown reasons
26+
# See https://github.com/jshttp/on-finished/pull/49 for more information.
27+
# - Node.js 9.x
2528
- Node.js 10.x
2629
- Node.js 11.x
2730
- Node.js 12.x
@@ -80,8 +83,13 @@ jobs:
8083

8184
- name: Node.js 8.x
8285
node-version: "8.17"
83-
npm-i: mocha@7.2.0
86+
npm-i: mocha@7.2.0 nyc@14.1.1
8487

88+
# test fail on Node.js 9.x for unknown reasons
89+
# See https://github.com/jshttp/on-finished/pull/49 for more information.
90+
# - name: Node.js 9.x
91+
# node-version: "9.11"
92+
# npm-i: mocha@7.2.0 nyc@14.1.1
8593
- name: Node.js 10.x
8694
node-version: "10.24"
8795
npm-i: mocha@8.4.0

0 commit comments

Comments
 (0)