RTECO-2022 - Fixed the bug in jf mvn --scan command

Author: naveenku-jfrog

artifactory/commands/mvn/mvn.go

@@ -16,6 +16,7 @@ import (
 	"github.com/jfrog/jfrog-cli-core/v2/utils/config"
 	"github.com/jfrog/jfrog-cli-core/v2/utils/ioutils"
 	"github.com/jfrog/jfrog-client-go/utils/errorutils"
+	"github.com/jfrog/jfrog-client-go/utils/io/content"
 	"github.com/jfrog/jfrog-client-go/utils/io/fileutils"
 	"github.com/jfrog/jfrog-client-go/utils/log"
 	"github.com/spf13/viper"
@@ -294,6 +295,23 @@ func (mc *MvnCommand) conditionalUpload() error {
 	if binariesSpecFile == nil {
 		return nil
 	}
+	// The --scan flag only requests an Xray scan for pass/fail gating; it must not, on its own, deploy artifacts.
+	// Artifacts are uploaded here only when the Maven goal actually requests deployment (i.e. "install"/"deploy").
+	// For non-deploy goals (e.g. "clean package --scan") the scan still gates the build, but nothing is uploaded.
+	if !mc.isDeploymentRequested() {
+		log.Info("Xray scan completed. Skipping upload because the Maven goal does not request deployment. Only 'install' and 'deploy' goals (including deploy:deploy-file) upload artifacts to Artifactory.")
+		// The scan already ran for pass/fail gating. Since nothing was uploaded, replace the result with an
+		// empty one so the command summary does not misreport the scanned artifacts as deployed.
+		if mc.result != nil && mc.result.Reader() != nil {
+			if e := mc.result.Reader().Close(); e != nil {
+				return e
+			}
+		}
+		emptyResult := new(commandsutils.Result)
+		emptyResult.SetReader(content.NewEmptyContentReader("files"))
+		mc.setResult(emptyResult)
+		return nil
+	}
 	// First upload binaries
 	if len(binariesSpecFile.Files) > 0 {
 		uploadCmd := generic.NewUploadCommand()