Support Arbitrary User-Defined Links - #164
Merged
Merged
Conversation
jeregrine
approved these changes
Jan 25, 2019
doomspork
requested changes
Jan 26, 2019
|
|
||
| defp merge_base_links(doc, data, view, conn) do | ||
| links = | ||
| %{self: view.url_for(data, conn)} |
Member
There was a problem hiding this comment.
Could we avoid using a pipeline here?
https://github.com/christopheradams/elixir_style_guide#bare-variables
JSON:API allows for a `links` object in the `data` payload (see https://jsonapi.org/format/#document-links). Prior to this commit we only included user-defined links should they be paginating. This commit ensures these links are always included unless otherwise specified by the `:remove_links` option. Resolves beam-community#141
doomspork
approved these changes
Jan 26, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON:API allows for a
linksobject in thedatapayload (seehttps://jsonapi.org/format/#document-links). Prior to this commit we
only included user-defined links should they be paginating. This commit
ensures these links are always included unless otherwise specified by
the
:remove_linksoption.Resolves #141