Split enforcer rules into validate and verify phases

Author: charphi

nbdemetra-app/pom.xml

@@ -134,6 +134,20 @@
                     <etcConfFile>src/main/resources/nbdemetra.conf</etcConfFile>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-enforcer-plugin</artifactId>
+                <configuration combine.children="merge">
+                    <rules>
+                        <banDuplicateClasses>
+                            <ignoreClasses>
+                                <ignoreClass>org.apache.commons.logging.*</ignoreClass>
+                                <ignoreClass>org.apache.commons.codec.*</ignoreClass>
+                            </ignoreClasses>
+                        </banDuplicateClasses>
+                    </rules>
+                </configuration>
+            </plugin>
         </plugins>
     </build>
 

pom.xml

@@ -533,7 +533,7 @@
                         </dependencies>
                         <executions>
                             <execution>
-                                <id>enforce</id>
+                                <id>enforce-on-validate</id>
                                 <goals>
                                     <goal>enforce</goal>
                                 </goals>
@@ -556,23 +556,35 @@
                                         </requireReleaseDeps>
                                         <requireUpperBoundDeps/>
                                         <!-- pomchecker-enforcer-rules -->
-                                        <checkMavenCentral
-                                                implementation="org.kordamp.maven.enforcer.checker.CheckMavenCentral">
+                                        <checkMavenCentral>
                                             <release>false</release>
                                             <strict>false</strict>
                                         </checkMavenCentral>
+                                        <!-- heylogs-enforcer-rules -->
+                                        <checkChangelog/>
+                                        <formatChangelog/>
+                                    </rules>
+                                </configuration>
+                            </execution>
+                            <execution>
+                                <id>enforce-on-verify</id>
+                                <phase>verify</phase>
+                                <goals>
+                                    <goal>enforce</goal>
+                                </goals>
+                                <configuration>
+                                    <rules>
                                         <!-- extra-enforcer-rules -->
                                         <banCircularDependencies/>
-                                        <!--                                        <banDuplicateClasses/>-->
+                                        <banDuplicateClasses>
+                                            <ignoredScopes>test</ignoredScopes>
+                                        </banDuplicateClasses>
                                         <enforceBytecodeVersion>
                                             <maxJdkVersion>8</maxJdkVersion>
                                             <ignoredScopes>
                                                 <ignoreScope>test</ignoreScope>
                                             </ignoredScopes>
                                         </enforceBytecodeVersion>
-                                        <!-- heylogs-enforcer-rules -->
-                                        <checkChangelog/>
-                                        <formatChangelog/>
                                     </rules>
                                 </configuration>
                             </execution>