add command line options to control compacting and comment removal - #754
Merged
Conversation
- there is no noCompact option in istanbul, only a compact option - add --[no-]compact and --[no-]preserve-comments and pass them on to istanbul
Contributor
Author
|
sorry about the test failures, I'm looking into them |
Member
|
@karottenreibe 👋 thanks for the contribution -- have had a hectic end of 2017, and haven't been the world's best at landing patches. but, patches are always greatly appreciated! feel free to join our community slack if you ever want to prod me and help move things along: http://devtoolscommunity.herokuapp.com/ I will work on getting this landed soon. |
Member
|
@karottenreibe please try |
This was referenced Mar 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
istanbul
I wasn't 100% sure what the default for preserveComments should be. Reading the code, it seemed to me that the intention was to have comments stripped by default but the current behaviour is to not strip comments, so I stuck with the current behaviour in order to keep the users' setups the same.
Please note that due to a bug in istanbul-lib-instrument, the preserveComments option set to false doesn't do anything yet. I filed another pull request with a fix for that as well: istanbuljs/istanbuljs#122
I hope the changes are OK, please let me know if not :-)