Skip to content

Create sourcemap in instrumented files - #674

Merged
bcoe merged 1 commit into
istanbuljs:masterfrom
schutm:master
Oct 15, 2017
Merged

Create sourcemap in instrumented files#674
bcoe merged 1 commit into
istanbuljs:masterfrom
schutm:master

Conversation

@schutm

@schutm schutm commented Sep 12, 2017

Copy link
Copy Markdown
Contributor

If invoked with nyc instrument it wasn's possible to attach the sourcemap. This created problems for me in the coverage reports created.

@bcoe

bcoe commented Sep 16, 2017

Copy link
Copy Markdown
Member

@schutm I'm not sure what the best solution is here such that you and @vanduynslagerp don't consistently break each-other's use-cases.

Is there a heuristic approach we could use so that both your applications of shouldInstrument work? I think we should make an effort to add a test for both so that we don't keep flip-flopping on this feature.

@schutm

schutm commented Sep 16, 2017

Copy link
Copy Markdown
Contributor Author

Agreed we shouldn't break each other changes, and test-cases should be there. However since this is in the CLI I didn't think it would break the previous changes.

For now seems I had a dangling comma; which I'll fix

@coveralls

coveralls commented Sep 17, 2017

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling be893c5 on schutm:master into ** on istanbuljs:master**.

@bcoe

bcoe commented Sep 17, 2017

Copy link
Copy Markdown
Member

@schutm I think this accidentally reverts https://github.com/istanbuljs/nyc/pull/667/files which would break @vanduynslagerp's use-case.

The instrument command is now able to create an instrumented output, with a sourcemap attached.
@coveralls

coveralls commented Sep 19, 2017

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 6f83f56 on schutm:master into ** on istanbuljs:master**.

@schutm

schutm commented Sep 19, 2017

Copy link
Copy Markdown
Contributor Author

@bcoe I removed the accidentally included index.js, which reverted #667. In addition I tidied the commits up to a single one.

@bcoe

bcoe commented Oct 15, 2017

Copy link
Copy Markdown
Member

@schutm this looks great 👍 sorry that this took so long to land.

@bcoe
bcoe merged commit f31d7a6 into istanbuljs:master Oct 15, 2017
@bcoe

bcoe commented Oct 23, 2017

Copy link
Copy Markdown
Member

@schutm try this out, and let me know if it does the trick:

npm i nyc@next --save-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants