Skip to content

Commit 8121fbe

Browse files
committed
Migrate from pkg_resources to importlib.metadata and importlib.resources
1 parent 0afbfe0 commit 8121fbe

6 files changed

Lines changed: 12 additions & 13 deletions

File tree

docs/conf.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import sys
1616
import io
1717
import re
18-
import pkg_resources
1918

2019
from os.path import dirname, join
2120
# Make `_theme` custom sphinx theme available

isso/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
#
2626
# Isso – a lightweight Disqus alternative
2727

28-
import pkg_resources
29-
dist = pkg_resources.get_distribution("isso")
28+
from importlib.metadata import version
29+
__version__ = version("isso")
3030

3131
# check if exectuable is `isso` and gevent is available
3232
import sys
@@ -232,7 +232,7 @@ def main():
232232
subparser = parser.add_subparsers(help="commands", dest="command")
233233

234234
parser.add_argument('--version', action='version',
235-
version='%(prog)s ' + dist.version)
235+
version='%(prog)s ' + __version__)
236236
parser.add_argument("-c", dest="conf", default="/etc/isso.cfg",
237237
metavar="/etc/isso.cfg", help="set configuration file")
238238

isso/config.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
import datetime
44
import logging
55
import os
6-
import pkg_resources
76
import re
87

98
from email.utils import parseaddr, formataddr
109
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
10+
from importlib.resources import files
1111

1212
logger = logging.getLogger("isso")
1313

14-
default_config_file = pkg_resources.resource_filename('isso', 'isso.cfg')
14+
default_config_file = str(files('isso').joinpath('isso.cfg'))
1515

1616

1717
def timedelta(string):

isso/utils/http.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
from urllib.parse import urlparse
88

9-
from isso import dist
9+
from isso import __version__
1010
from isso.wsgi import urlsplit
1111

1212
MAX_RETRY_COUNT = 3
@@ -24,7 +24,7 @@ class curl(object):
2424
"""
2525

2626
headers = {
27-
"User-Agent": "Isso/{0} (+https://isso-comments.de)".format(dist.version)
27+
"User-Agent": "Isso/{0} (+https://isso-comments.de)".format(__version__)
2828
}
2929

3030
def __init__(self, method, host, path, timeout=3):

isso/views/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# -*- encoding: utf-8 -*-
22

3-
import pkg_resources
4-
dist = pkg_resources.get_distribution("isso")
3+
from importlib.metadata import version
4+
__version__ = version("isso")
55

66
import json
77

@@ -81,7 +81,7 @@ def __init__(self, isso):
8181
def show(self, environ, request):
8282

8383
rv = {
84-
"version": dist.version,
84+
"version": __version__,
8585
"host": str(local("host")),
8686
"origin": str(local("origin")),
8787
"moderation": self.moderation,

isso/views/comments.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
import time
66
import functools
77
import json # json.dumps to put URL in <script>
8-
import pkg_resources
98

109
from configparser import NoOptionError
10+
from importlib.resources import files
1111
from datetime import datetime, timedelta
1212
from html import escape
1313
from io import BytesIO as StringIO
@@ -1416,7 +1416,7 @@ def config(self, environment, request):
14161416
</body>
14171417
"""
14181418
def demo(self, env, req):
1419-
index = pkg_resources.resource_filename('isso', 'demo/index.html')
1419+
index = str(files('isso').joinpath('demo/index.html'))
14201420
return send_from_directory(os_path.dirname(index), 'index.html', env)
14211421

14221422
"""

0 commit comments

Comments
 (0)