Do not crash on nested negative extglobs

This is still doing the wrong thing wrt Bash 4.3 on *(!(*.js)) not
matching foo.js, though.  Same with +(!(*.js)).

+(!(*.js)) is like !(*.js) or !(*.js)!(*.js) or ...

Thanks to koala_man in IRC #bash channel on Freenode for helping
understand this.

Nevertheless, this fixes #68, albeit imperfectly.

Author: isaacs

minimatch.js

@@ -570,11 +570,24 @@ function parse (pattern, isSub) {
     var nlFirst = re.slice(nl.reStart, nl.reEnd - 8)
     var nlLast = re.slice(nl.reEnd - 8, nl.reEnd)
     var nlAfter = re.slice(nl.reEnd)
+
+    nlLast += nlAfter
+
+    // Handle nested stuff like *(*.js|!(*.json)), where open parens
+    // mean that we should *not* include the ) in the bit that is considered
+    // "after" the negated section.
+    var openParensBefore = nlBefore.split('(').length - 1
+    var cleanAfter = nlAfter
+    for (i = 0; i < openParensBefore; i++) {
+      cleanAfter = cleanAfter.replace(/\)[+*?]?/, '')
+    }
+    nlAfter = cleanAfter
+
     var dollar = ''
     if (nlAfter === '' && isSub !== SUBPARSE) {
       dollar = '$'
     }
-    var newRe = nlBefore + nlFirst + nlAfter + dollar + nlLast + nlAfter
+    var newRe = nlBefore + nlFirst + nlAfter + dollar + nlLast
     re = newRe
   }
 

test/tricky-negations.js

@@ -72,6 +72,27 @@ var cases = {
 
   'foo.js.js': {
     '*.!(js)': true
+  },
+
+  'testjson.json': {
+    '*(*.json|!(*.js))': true,
+    '+(*.json|!(*.js))': true,
+    '@(*.json|!(*.js))': true,
+    '?(*.json|!(*.js))': true
+  },
+
+  'foojs.js': {
+    '*(*.json|!(*.js))': false, // XXX bash 4.3 disagrees!
+    '+(*.json|!(*.js))': false, // XXX bash 4.3 disagrees!
+    '@(*.json|!(*.js))': false,
+    '?(*.json|!(*.js))': false
+  },
+
+  'other.bar': {
+    '*(*.json|!(*.js))': true,
+    '+(*.json|!(*.js))': true,
+    '@(*.json|!(*.js))': true,
+    '?(*.json|!(*.js))': true
   }
 
 }