Skip to content

benchmark: fix wrk check - #1076

Closed
mscdex wants to merge 1 commit into
nodejs:v1.xfrom
mscdex:fix-benchmark-wrk-check
Closed

benchmark: fix wrk check#1076
mscdex wants to merge 1 commit into
nodejs:v1.xfrom
mscdex:fix-benchmark-wrk-check

Conversation

@mscdex

@mscdex mscdex commented Mar 5, 2015

Copy link
Copy Markdown
Contributor

Evidently .error is undefined if there was no error.

@cjihrig

cjihrig commented Mar 5, 2015

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@jbergstroem

Copy link
Copy Markdown
Member

LGTM

mscdex added a commit to mscdex/io.js that referenced this pull request Mar 5, 2015
PR-URL: nodejs#1076
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mscdex

mscdex commented Mar 5, 2015

Copy link
Copy Markdown
Contributor Author

Landed in b27931b.

@mscdex mscdex closed this Mar 5, 2015
@mscdex
mscdex deleted the fix-benchmark-wrk-check branch March 5, 2015 22:14
@rvagg rvagg mentioned this pull request Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants