fix(cpp): fix CsvReader::parse_value scope and Frame constructor calls

Author: im-anishraj

cpp/src/csv_reader.cpp

@@ -663,28 +663,7 @@ void CsvParser::parse_line(const std::string& line, std::vector<std::string>& fi
     }
 }
 
-DType CsvReader::infer_type(const std::string& value) const {
-    if (value.empty()) return DType::NULL_TYPE;
 
-    // Check configurable null sentinel values (pandas-compatible defaults)
-    if (config_.null_values.count(value)) return DType::NULL_TYPE;
-
-    // Try bool
-    std::string lower = value;
-    std::transform(lower.begin(), lower.end(), lower.begin(), ::tolower);
-    if (lower == "true" || lower == "false") return DType::BOOL;
-
-    // Try int64
-    {
-        const char* start = value.c_str();
-        char* end = nullptr;
-        long long val = std::strtoll(start, &end, 10);
-        (void)val;
-        if (end != start && *end == '\0') return DType::INT64;
-    }
-
-    return value.empty();
-}
 
 DType CsvParser::infer_type(const std::string& value) const {
     const std::string sanitized = handle_utf8_errors(value, config_.encoding_errors);
@@ -761,8 +740,9 @@ DType CsvParser::promote_type(DType current, DType incoming) {
     return DType::STRING;
 }
 
-CellValue CsvReader::parse_value(const std::string& raw, DType dtype) {
-    if (raw.empty() || config_.null_values.count(raw)) return std::monostate{};
+CellValue CsvParser::parse_value(const std::string& raw, DType dtype, bool is_forced) const {
+    const std::string sanitized = handle_utf8_errors(raw, config_.encoding_errors);
+    if (is_null_sentinel(sanitized)) return std::monostate{};
 
     switch (dtype) {
         case DType::BOOL: {

cpp/src/frame.cpp

@@ -100,7 +100,7 @@ Frame Frame::clone() const {
     for (const auto& col : columns_) {
         cloned.push_back(col.clone());
     }
-    return Frame(row_count_, std::move(cloned));
+    return Frame(std::move(cloned), row_count_);
 }
 
 void Frame::validate_column_size(const Column& col) const {
@@ -119,7 +119,7 @@ Frame Frame::select_columns(const std::vector<std::string>& columns) const {
         selected.push_back(column(name).clone());
     }
 
-    return Frame(row_count_, std::move(selected));
+    return Frame(std::move(selected), row_count_);
 }
 
 Frame Frame::select_rows(size_t start, size_t count) const {
@@ -159,7 +159,7 @@ Frame Frame::select_rows(size_t start, size_t count) const {
         selected_columns.push_back(std::move(new_col));
     }
 
-    return Frame(actual_count, std::move(selected_columns));
+    return Frame(std::move(selected_columns), actual_count);
 }
 
 void Frame::rebuild_index() {
@@ -169,7 +169,6 @@ void Frame::rebuild_index() {
     }
 }
 
- main
 
 std::vector<std::pair<std::string, std::vector<std::pair<std::string, double>>>> Frame::describe()
     const {
@@ -327,5 +326,5 @@ std::vector<std::pair<std::string, std::vector<std::pair<std::string, double>>>>
     return summary;
 }
 
- main
+
 }  // namespace arnio