Skip to content

Commit 796decd

Browse files
igerberclaude
andcommitted
Address PR #443 R5 review (1 P2, TROP source-ambiguity consistency)
athey-2025-review.md: - Reframe Methodology Registry Entry intro from "copy into REGISTRY" ready-to-promote to a working-draft framing that explicitly defers promotion until two source-ambiguity items (weight normalization, Eq. 13 penalty form) are resolved against the source - Pull the weight-normalization line out of the Requirements Checklist (it was framed as a settled requirement); restate it as an open source-ambiguity cross-referencing Gap #5, with the current shipped implementation pinned to the Equation 2 (unnormalized) interpretation Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 6dbddf7 commit 796decd

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

docs/methodology/papers/athey-2025-review.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
## Methodology Registry Entry
1111

12-
*Formatted to match docs/methodology/REGISTRY.md structure. Heading levels and labels align with existing entries -- copy the `## TROP` section into the appropriate category in the registry.*
12+
*Working draft formatted to match docs/methodology/REGISTRY.md structure. Heading levels and labels align with existing entries. Two open source-ambiguity items remain (weight normalization and Eq. 13 penalty form — see "Gaps and Uncertainties" below); resolve those against the source before promoting this section into REGISTRY.md.*
1313

1414
## TROP
1515

@@ -264,7 +264,7 @@ Note: Stratified bootstrap -- control and treated units resampled separately. Pr
264264
- [ ] Stratified bootstrap preserving unit-level structure (Algorithm 3)
265265
- [ ] Covariate extension supported (Equation 14)
266266
- [ ] Special cases recoverable: DID, MC, SC, SDID via tuning parameters
267-
- [ ] Weight normalization: `1^T omega = 1^T theta = 1` (Section 5, page 20)
267+
- Weight normalization (`1^T omega = 1^T theta = 1`, Section 5, page 20)**open source-ambiguity item**; see Gap #5 below. Section 5 states sum-to-one, Equation 3 / Equation 2 use unnormalized exponential weights, and the shipped implementation matches Equation 2. Do not promote this to a requirement until the discrepancy is resolved against the source.
268268
- [ ] Heterogeneous treatment effects supported via per-observation estimation (Remark 6.1)
269269

270270
---

0 commit comments

Comments
 (0)