Remove deprecated close and free functions

Author: jamieburchell

composer.json

@@ -11,7 +11,7 @@
 		"source": "https://github.com/bcit-ci/CodeIgniter"
 	},
 	"require": {
-		"php": ">=7.4"
+		"php": ">=8.0"
 	},
 	"scripts": {
 		"test:coverage": [

system/helpers/captcha_helper.php

@@ -346,7 +346,6 @@ function create_captcha($data = '', $img_path = '', $img_url = '', $font_path =
 		}
 
 		$img = '<img '.($img_id === '' ? '' : 'id="'.$img_id.'"').' src="'.$img_url.$img_filename.'" style="width: '.$img_width.'px; height: '.$img_height .'px; border: 0;" alt=" " />';
-		ImageDestroy($im);
 
 		return array('word' => $word, 'time' => $now, 'image' => $img, 'filename' => $img_filename);
 	}

system/libraries/Image_lib.php

@@ -840,10 +840,6 @@ public function image_process_gd($action = 'resize')
 			return FALSE;
 		}
 
-		// Kill the file handles
-		imagedestroy($dst_img);
-		imagedestroy($src_img);
-
 		if ($this->dynamic_output !== TRUE)
 		{
 			chmod($this->full_dst_path, $this->file_permissions);
@@ -1045,10 +1041,6 @@ public function image_rotate_gd()
 			return FALSE;
 		}
 
-		// Kill the file handles
-		imagedestroy($dst_img);
-		imagedestroy($src_img);
-
 		chmod($this->full_dst_path, $this->file_permissions);
 
 		return TRUE;
@@ -1124,9 +1116,6 @@ public function image_mirror_gd()
 			return FALSE;
 		}
 
-		// Kill the file handles
-		imagedestroy($src_img);
-
 		chmod($this->full_dst_path, $this->file_permissions);
 
 		return TRUE;
@@ -1255,9 +1244,6 @@ public function overlay_watermark()
 			return FALSE;
 		}
 
-		imagedestroy($src_img);
-		imagedestroy($wm_img);
-
 		return TRUE;
 	}
 
@@ -1426,8 +1412,6 @@ public function text_watermark()
 			$this->image_save_gd($src_img);
 		}
 
-		imagedestroy($src_img);
-
 		return TRUE;
 	}
 

system/libraries/Upload.php

@@ -1231,7 +1231,6 @@ protected function _file_mime_type($file)
 			if ($finfo !== FALSE) // It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system
 			{
 				$mime = @finfo_file($finfo, $file['tmp_name']);
-				finfo_close($finfo);
 
 				/* According to the comments section of the PHP manual page,
 				 * it is possible that this function returns an empty string

system/libraries/Xmlrpc.php

@@ -1185,10 +1185,8 @@ public function parseResponse($fp)
 						xml_get_current_line_number($parser));
 
 			$r = new XML_RPC_Response(0, $this->xmlrpcerr['invalid_return'], $this->xmlrpcstr['invalid_return']);
-			xml_parser_free($parser);
 			return $r;
 		}
-		xml_parser_free($parser);
 
 		// Got ourselves some badness, it seems
 		if ($this->xh['isf'] > 1)

system/libraries/Xmlrpcs.php

@@ -262,16 +262,13 @@ public function parseRequest($data = '')
 				sprintf('XML error: %s at line %d',
 				xml_error_string(xml_get_error_code($parser)),
 				xml_get_current_line_number($parser)));
-			xml_parser_free($parser);
 		}
 		elseif ($parser_object->xh['isf'])
 		{
 			return new XML_RPC_Response(0, $this->xmlrpcerr['invalid_return'], $this->xmlrpcstr['invalid_return']);
 		}
 		else
 		{
-			xml_parser_free($parser);
-
 			$m = new XML_RPC_Message($parser_object->xh['method']);
 			$plist = '';