Skip to content

fix: more strict delimiter in REGEX_PARSE - #1555

Merged
iamkun merged 1 commit into
iamkun:devfrom
FourwingsY:dev
Jul 1, 2021
Merged

fix: more strict delimiter in REGEX_PARSE#1555
iamkun merged 1 commit into
iamkun:devfrom
FourwingsY:dev

Conversation

@FourwingsY

@FourwingsY FourwingsY commented Jun 28, 2021

Copy link
Copy Markdown
Contributor

resolving #1554

@codecov

codecov Bot commented Jun 28, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1555 (1f9cb24) into dev (f369844) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1555   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          176       176           
  Lines         1980      1980           
  Branches       502       502           
=========================================
  Hits          1980      1980
Impacted Files Coverage Δ
src/constant.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f369844...1f9cb24. Read the comment docs.

iamkun
iamkun reviewed Jun 29, 2021
View reviewed changes
Comment thread src/constant.js

// regex
export const REGEX_PARSE = /^(\d{4})[-/]?(\d{1,2})?[-/]?(\d{0,2})[^0-9]*(\d{1,2})?:?(\d{1,2})?:?(\d{1,2})?[.:]?(\d+)?$/
export const REGEX_PARSE = /^(\d{4})[-/]?(\d{1,2})?[-/]?(\d{0,2})[Tt\s]*(\d{1,2})?:?(\d{1,2})?:?(\d{1,2})?[.:]?(\d+)?$/

@iamkun iamkun Jun 29, 2021

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why a Tt here?

@FourwingsY FourwingsY Jun 29, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is T is enough? I searched some regex for ISO8601 format and they were using Tt instead of T. I guess thats for some compatibility of some OS or libraries.

@iamkun iamkun Jun 29, 2021

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

@iamkun
iamkun merged commit bfdab5c into iamkun:dev Jul 1, 2021
iamkun pushed a commit that referenced this pull request Jul 6, 2021
@semantic-release-bot
chore(release): 1.10.6 [skip ci]
42e494b 
## [1.10.6](v1.10.5...v1.10.6) (2021-07-06)

### Bug Fixes

* add invalid date string override ([#1465](#1465)) ([#1470](#1470)) ([06f88f4](06f88f4))
* add sv-fi Finland Swedish locale ([#1522](#1522)) ([8e32164](8e32164))
* customParseFormat support parsing X x timestamp ([#1567](#1567)) ([eb087f5](eb087f5))
* dayjs ConfigTypeMap add null & undefined ([#1560](#1560)) ([b5e40e6](b5e40e6))
* Fix DayOfYear plugin when using BadMutable plugin ([#1511](#1511)) ([0b0c6a3](0b0c6a3))
* Implement ordinal in Bulgarian translation (fixes [#1501](#1501)) ([#1502](#1502)) ([b728da5](b728da5))
* more strict delimiter in REGEX_PARSE ([#1555](#1555)) ([bfdab5c](bfdab5c))
* parameter type ([#1549](#1549)) ([f369844](f369844))
* update customParseFormat plugin to custom two-digit year parse function ([#1421](#1421)) ([bb5df55](bb5df55))
* update names of weekdays and months in Bulgarian [bg] to lowercase ([#1438](#1438)) ([b246210](b246210))
* update type file `.diff` ([#1505](#1505)) ([6508494](6508494))
* update UTC plugin type file for strict parsing ([#1443](#1443)) ([b4f28df](b4f28df))
@iamkun

iamkun commented Jul 6, 2021

Copy link
Copy Markdown
Owner

🎉 This PR is included in version 1.10.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Jul 6, 2021
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.10.6 [skip ci]
ff72724 
## [1.10.6](iamkun/dayjs@v1.10.5...v1.10.6) (2021-07-06)

### Bug Fixes

* add invalid date string override ([#1465](iamkun/dayjs#1465)) ([#1470](iamkun/dayjs#1470)) ([06f88f4](iamkun/dayjs@06f88f4))
* add sv-fi Finland Swedish locale ([#1522](iamkun/dayjs#1522)) ([8e32164](iamkun/dayjs@8e32164))
* customParseFormat support parsing X x timestamp ([#1567](iamkun/dayjs#1567)) ([eb087f5](iamkun/dayjs@eb087f5))
* dayjs ConfigTypeMap add null & undefined ([#1560](iamkun/dayjs#1560)) ([b5e40e6](iamkun/dayjs@b5e40e6))
* Fix DayOfYear plugin when using BadMutable plugin ([#1511](iamkun/dayjs#1511)) ([0b0c6a3](iamkun/dayjs@0b0c6a3))
* Implement ordinal in Bulgarian translation (fixes [#1501](iamkun/dayjs#1501)) ([#1502](iamkun/dayjs#1502)) ([b728da5](iamkun/dayjs@b728da5))
* more strict delimiter in REGEX_PARSE ([#1555](iamkun/dayjs#1555)) ([bfdab5c](iamkun/dayjs@bfdab5c))
* parameter type ([#1549](iamkun/dayjs#1549)) ([f369844](iamkun/dayjs@f369844))
* update customParseFormat plugin to custom two-digit year parse function ([#1421](iamkun/dayjs#1421)) ([bb5df55](iamkun/dayjs@bb5df55))
* update names of weekdays and months in Bulgarian [bg] to lowercase ([#1438](iamkun/dayjs#1438)) ([b246210](iamkun/dayjs@b246210))
* update type file `.diff` ([#1505](iamkun/dayjs#1505)) ([6508494](iamkun/dayjs@6508494))
* update UTC plugin type file for strict parsing ([#1443](iamkun/dayjs#1443)) ([b4f28df](iamkun/dayjs@b4f28df))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.10.6 [skip ci]
3798db5 
## [1.10.6](iamkun/dayjs@v1.10.5...v1.10.6) (2021-07-06)

### Bug Fixes

* add invalid date string override ([#1465](iamkun/dayjs#1465)) ([#1470](iamkun/dayjs#1470)) ([06f88f4](iamkun/dayjs@06f88f4))
* add sv-fi Finland Swedish locale ([#1522](iamkun/dayjs#1522)) ([8e32164](iamkun/dayjs@8e32164))
* customParseFormat support parsing X x timestamp ([#1567](iamkun/dayjs#1567)) ([eb087f5](iamkun/dayjs@eb087f5))
* dayjs ConfigTypeMap add null & undefined ([#1560](iamkun/dayjs#1560)) ([b5e40e6](iamkun/dayjs@b5e40e6))
* Fix DayOfYear plugin when using BadMutable plugin ([#1511](iamkun/dayjs#1511)) ([0b0c6a3](iamkun/dayjs@0b0c6a3))
* Implement ordinal in Bulgarian translation (fixes [#1501](iamkun/dayjs#1501)) ([#1502](iamkun/dayjs#1502)) ([b728da5](iamkun/dayjs@b728da5))
* more strict delimiter in REGEX_PARSE ([#1555](iamkun/dayjs#1555)) ([bfdab5c](iamkun/dayjs@bfdab5c))
* parameter type ([#1549](iamkun/dayjs#1549)) ([f369844](iamkun/dayjs@f369844))
* update customParseFormat plugin to custom two-digit year parse function ([#1421](iamkun/dayjs#1421)) ([bb5df55](iamkun/dayjs@bb5df55))
* update names of weekdays and months in Bulgarian [bg] to lowercase ([#1438](iamkun/dayjs#1438)) ([b246210](iamkun/dayjs@b246210))
* update type file `.diff` ([#1505](iamkun/dayjs#1505)) ([6508494](iamkun/dayjs@6508494))
* update UTC plugin type file for strict parsing ([#1443](iamkun/dayjs#1443)) ([b4f28df](iamkun/dayjs@b4f28df))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
@semantic-release-bot
chore(release): 1.10.6 [skip ci]
799551a 
## [1.10.6](iamkun/dayjs@v1.10.5...v1.10.6) (2021-07-06)

### Bug Fixes

* add invalid date string override ([#1465](iamkun/dayjs#1465)) ([#1470](iamkun/dayjs#1470)) ([06f88f4](iamkun/dayjs@06f88f4))
* add sv-fi Finland Swedish locale ([#1522](iamkun/dayjs#1522)) ([8e32164](iamkun/dayjs@8e32164))
* customParseFormat support parsing X x timestamp ([#1567](iamkun/dayjs#1567)) ([eb087f5](iamkun/dayjs@eb087f5))
* dayjs ConfigTypeMap add null & undefined ([#1560](iamkun/dayjs#1560)) ([b5e40e6](iamkun/dayjs@b5e40e6))
* Fix DayOfYear plugin when using BadMutable plugin ([#1511](iamkun/dayjs#1511)) ([0b0c6a3](iamkun/dayjs@0b0c6a3))
* Implement ordinal in Bulgarian translation (fixes [#1501](iamkun/dayjs#1501)) ([#1502](iamkun/dayjs#1502)) ([b728da5](iamkun/dayjs@b728da5))
* more strict delimiter in REGEX_PARSE ([#1555](iamkun/dayjs#1555)) ([bfdab5c](iamkun/dayjs@bfdab5c))
* parameter type ([#1549](iamkun/dayjs#1549)) ([f369844](iamkun/dayjs@f369844))
* update customParseFormat plugin to custom two-digit year parse function ([#1421](iamkun/dayjs#1421)) ([bb5df55](iamkun/dayjs@bb5df55))
* update names of weekdays and months in Bulgarian [bg] to lowercase ([#1438](iamkun/dayjs#1438)) ([b246210](iamkun/dayjs@b246210))
* update type file `.diff` ([#1505](iamkun/dayjs#1505)) ([6508494](iamkun/dayjs@6508494))
* update UTC plugin type file for strict parsing ([#1443](iamkun/dayjs#1443)) ([b4f28df](iamkun/dayjs@b4f28df))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamkun iamkun iamkun left review comments

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FourwingsY @iamkun