Commit bea9bf1
committed
fix(pages): rename _shared.lua -> shared.lua so GitHub Pages serves it
Irish transcription was returning 404 in production for
wiktionary_pron/lua_modules/ga-passes/_shared.lua, breaking the language
entirely — all 17 passes plus the engine require that module, so the first
fetch failed and nothing transcribed.
Cause: the Pages build runs actions/jekyll-build-pages, and Jekyll excludes
any path whose basename starts with an underscore. Proven in production: in
the same directory and commit, 01_polarity.lua and init.lua return 200 while
_shared.lua returns 404.
The previous attempt (9c20c06) added _config.yml with an `include:` entry for
the path. That did NOT work — the deploy ran on that commit and succeeded, and
the file was still 404, because jekyll-build-pages runs in safe mode with
GitHub's own config overrides and ignores a repo _config.yml. (.nojekyll is
likewise irrelevant: it only bypasses the legacy Pages pipeline, not an
explicit build action.) That file is removed here.
Renaming is the fix that actually holds: no underscore, nothing for Jekyll to
strip. Mechanical change — one require form, `require("ga-passes._shared")` ->
`require("ga-passes.shared")`, across 19 files. The internal `local _shared`
variable is untouched; it is just an identifier.
Note for future syncs: the source repo
(wiktionary_ipa_phoneme_lexicons/irish/passes/) still names the module
_shared.lua, since it never goes through Jekyll. Syncing is therefore no longer
a pure `passes.` -> `ga-passes.` rewrite — it must also map `_shared` ->
`shared`.
Verified locally: golden 81 pass, transcription e2e 13/13 pass. Production
verification requires a redeploy.1 parent 9c20c06 commit bea9bf1
21 files changed
Lines changed: 19 additions & 35 deletions
File tree
- wiktionary_pron/lua_modules
- ga-passes
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
0 commit comments