Skip to content

Commit 736d087

Browse files
authored
chore: upgrade rusty_v8 to 0.55.0 (denoland#16604)
<!-- Before submitting a PR, please read http://deno.land/manual/contributing 1. Give the PR a descriptive title. Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports Examples of bad title: - fix denoland#7123 - update docs - fix bugs 2. Ensure there is a related issue and it is referenced in the PR text. 3. Ensure there are tests that cover the changes. 4. Ensure `cargo test` passes. 5. Ensure `./tools/format.js` passes without changing files. 6. Ensure `./tools/lint.js` passes. -->
1 parent f838d70 commit 736d087

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

serde_v8/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ derive_more = "0.99.17"
1818
serde = { version = "1.0.136", features = ["derive"] }
1919
serde_bytes = "0.11"
2020
smallvec = { version = "1.8", features = ["union"] }
21-
v8 = { version = "0.54.0", default-features = false }
21+
v8 = { version = "0.55.0", default-features = false }
2222

2323
[dev-dependencies]
2424
bencher = "0.1"

serde_v8/magic/detached_buffer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ impl FromV8 for DetachedBuffer {
6363
return Err(crate::Error::ExpectedDetachable);
6464
}
6565
let store = b.get_backing_store();
66-
b.detach(); // Detach
66+
b.detach(v8::undefined(scope).into()); // Detach
6767
Ok(Self(V8Slice { store, range }))
6868
}
6969
}

0 commit comments

Comments
 (0)