Apply code review changes

Author: mcelicalderon

app/graphql/graphql_devise/mutations/update_password.rb

@@ -14,7 +14,7 @@ def resolve(current_password: nil, **attrs)
           )
         end
 
-        if update_cresource_password(current_password, attrs)
+        if update_resource_password(current_password, attrs)
           current_resource.allow_password_change = false if recoverable_enabled?
           current_resource.save!
 
@@ -31,7 +31,7 @@ def resolve(current_password: nil, **attrs)
 
       private
 
-      def update_cresource_password(current_password, attrs)
+      def update_resource_password(current_password, attrs)
         allow_password_change = recoverable_enabled? && current_resource.allow_password_change == true
         if DeviseTokenAuth.check_current_password_before_update == false || allow_password_change
           current_resource.public_send(:update, attrs)

lib/graphql_devise.rb

@@ -3,10 +3,10 @@
 require 'devise_token_auth'
 require 'graphql'
 require 'graphql_devise/version'
+require 'graphql_devise/error_codes'
+require 'graphql_devise/user_error'
+require 'graphql_devise/detailed_user_error'
 
 module GraphqlDevise
   class Error < StandardError; end
 end
-
-require 'graphql_devise/user_error'
-require 'graphql_devise/detailed_user_error'

lib/graphql_devise/detailed_user_error.rb

@@ -8,7 +8,7 @@ def initialize(message, errors:)
     end
 
     def to_h
-      super.merge(extensions: { code: 'USER_ERROR', detailed_errors: @errors })
+      super.merge(extensions: { code: ERROR_CODES.fetch(:user_error), detailed_errors: @errors })
     end
   end
 end

lib/graphql_devise/error_codes.rb

@@ -0,0 +1,5 @@
+module GraphqlDevise
+  ERROR_CODES = {
+    user_error: 'USER_ERROR'
+  }.freeze
+end

lib/graphql_devise/user_error.rb

@@ -1,7 +1,7 @@
 module GraphqlDevise
   class UserError < GraphQL::ExecutionError
     def to_h
-      super.merge(extensions: { code: 'USER_ERROR' })
+      super.merge(extensions: { code: ERROR_CODES.fetch(:user_error) })
     end
   end
 end

spec/requests/mutations/update_password_spec.rb

@@ -13,6 +13,7 @@
         authenticable: { email: user.email }
       )
       expect(json_response[:errors]).to be_nil
+      expect(user).to be_valid_password(password)
     end
   end