Add tests for model without mutations

Author: David Revelo

lib/graphql_devise/rails/routes.rb

@@ -27,7 +27,11 @@ def mount_graphql_devise_for(resource, opts = {})
         skipped: skipped_operations
       }
 
-      validate_gql_devise_operations!(param_operations)
+      GraphqlDevise::OperationChecker.call(
+        mutations: GraphqlDevise::MutationsPreparer::DEFAULT_MUTATIONS,
+        queries:   GraphqlDevise::QueriesPreparer::DEFAULT_QUERIES,
+        **param_operations
+      )
 
       devise_for(
         resource.pluralize.underscore.tr('/', '_').to_sym,
@@ -65,15 +69,5 @@ def mount_graphql_devise_for(resource, opts = {})
         get  path, to: 'graphql_devise/graphql#auth'
       end
     end
-
-    private
-
-    def validate_gql_devise_operations!(param_operations)
-      GraphqlDevise::OperationChecker.call(
-        mutations: GraphqlDevise::MutationsPreparer::DEFAULT_MUTATIONS,
-        queries:   GraphqlDevise::QueriesPreparer::DEFAULT_QUERIES,
-        **param_operations
-      )
-    end
   end
 end

spec/dummy/app/models/invitee.rb

@@ -0,0 +1,6 @@
+class Invitee < ActiveRecord::Base
+  devise :database_authenticatable, :registerable, :confirmable,
+         :recoverable, :rememberable, :trackable, :validatable
+
+  include GraphqlDevise::Concerns::Model
+end

spec/dummy/config/routes.rb

@@ -21,5 +21,11 @@
     at:   '/api/v1/guest/graphql_auth'
   )
 
+  mount_graphql_devise_for(
+    'Invitee',
+    only: [:confirm_account, :check_password_token],
+    at:   '/api/v1/invitee/graphql_auth'
+  )
+
   post '/api/v1/graphql', to: 'api/v1/graphql#graphql'
 end

spec/dummy/db/migrate/20200315133915_devise_token_auth_create_invitees.rb

@@ -0,0 +1,49 @@
+class DeviseTokenAuthCreateInvitees < ActiveRecord::Migration[6.0]
+  def change
+    
+    create_table(:invitees) do |t|
+      ## Required
+      t.string :provider, :null => false, :default => "email"
+      t.string :uid, :null => false, :default => ""
+
+      ## Database authenticatable
+      t.string :encrypted_password, :null => false, :default => ""
+
+      ## Recoverable
+      t.string   :reset_password_token
+      t.datetime :reset_password_sent_at
+      t.boolean  :allow_password_change, :default => false
+
+      ## Rememberable
+      t.datetime :remember_created_at
+
+      ## Confirmable
+      t.string   :confirmation_token
+      t.datetime :confirmed_at
+      t.datetime :confirmation_sent_at
+      t.string   :unconfirmed_email # Only if using reconfirmable
+
+      ## Lockable
+      # t.integer  :failed_attempts, :default => 0, :null => false # Only if lock strategy is :failed_attempts
+      # t.string   :unlock_token # Only if unlock strategy is :email or :both
+      # t.datetime :locked_at
+
+      ## User Info
+      t.string :name
+      t.string :nickname
+      t.string :image
+      t.string :email
+
+      ## Tokens
+      t.text :tokens
+
+      t.timestamps
+    end
+
+    add_index :invitees, :email,                unique: true
+    add_index :invitees, [:uid, :provider],     unique: true
+    add_index :invitees, :reset_password_token, unique: true
+    add_index :invitees, :confirmation_token,   unique: true
+    # add_index :invitees, :unlock_token,       unique: true
+  end
+end

spec/dummy/db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2019_10_13_213045) do
+ActiveRecord::Schema.define(version: 2020_03_15_133915) do
 
   create_table "admins", force: :cascade do |t|
     t.string "provider", default: "email", null: false
@@ -54,6 +54,31 @@
     t.index ["uid", "provider"], name: "index_guests_on_uid_and_provider", unique: true
   end
 
+  create_table "invitees", force: :cascade do |t|
+    t.string "provider", default: "email", null: false
+    t.string "uid", default: "", null: false
+    t.string "encrypted_password", default: "", null: false
+    t.string "reset_password_token"
+    t.datetime "reset_password_sent_at"
+    t.boolean "allow_password_change", default: false
+    t.datetime "remember_created_at"
+    t.string "confirmation_token"
+    t.datetime "confirmed_at"
+    t.datetime "confirmation_sent_at"
+    t.string "unconfirmed_email"
+    t.string "name"
+    t.string "nickname"
+    t.string "image"
+    t.string "email"
+    t.text "tokens"
+    t.datetime "created_at", precision: 6, null: false
+    t.datetime "updated_at", precision: 6, null: false
+    t.index ["confirmation_token"], name: "index_invitees_on_confirmation_token", unique: true
+    t.index ["email"], name: "index_invitees_on_email", unique: true
+    t.index ["reset_password_token"], name: "index_invitees_on_reset_password_token", unique: true
+    t.index ["uid", "provider"], name: "index_invitees_on_uid_and_provider", unique: true
+  end
+
   create_table "users", force: :cascade do |t|
     t.string "provider", default: "email", null: false
     t.string "uid", default: "", null: false

spec/factories/invitee.rb

@@ -0,0 +1,19 @@
+FactoryBot.define do
+  factory :invitee do
+    name      { Faker::FunnyName.two_word_name }
+    email     { Faker::Internet.unique.email }
+    password  { Faker::Internet.password }
+
+    trait :confirmed do
+      confirmed_at { Time.now }
+    end
+
+    trait :locked do
+      locked_at { Time.now }
+    end
+
+    trait :auth_unavailable do
+      auth_available { false }
+    end
+  end
+end

spec/mutations_preparer_spec.rb

@@ -11,10 +11,10 @@
     end
 
     let(:resource)  { 'User' }
-    let(:class_1)   { Class.new(GraphQL::Schema::Mutation) }
-    let(:class_2)   { GraphQL::Schema::Mutation }
+    let(:class1)    { Class.new(GraphQL::Schema::Mutation) }
+    let(:class2)    { GraphQL::Schema::Mutation }
     let(:auth_type) { GraphqlDevise::Types::AuthenticatableType }
-    let(:mutations) { { mutation_1: class_1, mutation_2: class_2 } }
+    let(:mutations) { { mutation_1: class1, mutation_2: class2 } }
 
     context 'when mutations is *NOT* empty' do
       it 'assign gql attibutes to mutations and changes keys using resource map' do

spec/operation_checker_spec.rb

@@ -14,8 +14,8 @@
       }
     end
 
-    let(:mutations) { { mutation_1: Class.new, mutation_2: Class.new } }
-    let(:queries)   { { query_1: Class.new, query_2: Class.new } }
+    let(:mutations) { { mutation1: Class.new, mutation2: Class.new } }
+    let(:queries)   { { query1: Class.new, query2: Class.new } }
     let(:custom)    { {} }
     let(:only)      { [] }
     let(:skipped)   { [] }
@@ -25,26 +25,26 @@
     end
 
     context 'when custom mutations and queries passed are among the defaults' do
-      let(:custom) { { mutation_1: Class.new, query_2: Class.new } }
+      let(:custom) { { mutation1: Class.new, query2: Class.new } }
 
       it { is_expected.not_to raise_error }
     end
 
     context 'when only operations are among the defaults' do
-      let(:only) { [:mutation_1, :query_2] }
+      let(:only) { [:mutation1, :query2] }
 
       it { is_expected.not_to raise_error }
     end
 
     context 'when skipped operations are among the defaults' do
-      let(:skipped) { [:mutation_2, :query_1] }
+      let(:skipped) { [:mutation2, :query1] }
 
       it { is_expected.not_to raise_error }
     end
 
     context 'when only and skipped operations are both defined' do
-      let(:only)    { [:mutation_1, :query_2] }
-      let(:skipped) { [:mutation_2, :query_1] }
+      let(:only)    { [:mutation1, :query2] }
+      let(:skipped) { [:mutation2, :query1] }
 
       it {
         is_expected.to(
@@ -57,39 +57,39 @@
     end
 
     context 'when custom operations include a not supported item' do
-      let(:custom) { { mutation_3: Class.new, query_2: Class.new } }
+      let(:custom) { { mutation3: Class.new, query2: Class.new } }
 
       it {
         is_expected.to(
           raise_error(
             GraphqlDevise::Error,
-            'Custom operation "mutation_3" is not supported. Check for typos.'
+            'Custom operation "mutation3" is not supported. Check for typos.'
           )
         )
       }
     end
 
     context 'when skipped operations include a not supported item' do
-      let(:skipped) { [:mutation_3, :query_2] }
+      let(:skipped) { [:mutation3, :query2] }
 
       it {
         is_expected.to(
           raise_error(
             GraphqlDevise::Error,
-            'Trying to skip unsupported operation "mutation_3". Check for typos.'
+            'Trying to skip unsupported operation "mutation3". Check for typos.'
           )
         )
       }
     end
 
     context 'when only operations include a not supported item' do
-      let(:only) { [:mutation_3, :query_2] }
+      let(:only) { [:mutation3, :query2] }
 
       it {
         is_expected.to(
           raise_error(
             GraphqlDevise::Error,
-            'The "only" operation "mutation_3" is not supported. Check for typos.'
+            'The "only" operation "mutation3" is not supported. Check for typos.'
           )
         )
       }

spec/operation_sanitizer_spec.rb

@@ -4,36 +4,36 @@
   describe '.call' do
     subject { described_class.call(default: default, custom: custom, only: only, skipped: skipped) }
 
-    let(:op_class_1) { Class.new }
-    let(:op_class_2) { Class.new }
-    let(:op_class_3) { Class.new }
+    let(:op_class1) { Class.new }
+    let(:op_class2) { Class.new }
+    let(:op_class3) { Class.new }
 
     context 'when the operations passed are mutations' do
       let(:custom)   { {} }
       let(:skipped)  { [] }
       let(:only)     { [] }
-      let(:default)  { { operation_1: op_class_1, operation_2: op_class_2 } }
+      let(:default)  { { operation1: op_class1, operation2: op_class2 } }
 
       context 'when no other option besides default is passed' do
         it { is_expected.to eq(default) }
       end
 
       context 'when there are custom operations' do
-        let(:custom) { { operation_1:   op_class_3, bad_operation: GraphQL::Schema::Resolver } }
+        let(:custom) { { operation1: op_class3, bad_operation: GraphQL::Schema::Resolver } }
 
-        it { is_expected.to eq(operation_1: op_class_3, operation_2: op_class_2) }
+        it { is_expected.to eq(operation1: op_class3, operation2: op_class2) }
       end
 
       context 'when there are only operations' do
-        let(:only) { [:operation_1] }
+        let(:only) { [:operation1] }
 
-        it { is_expected.to eq(operation_1: op_class_1) }
+        it { is_expected.to eq(operation1: op_class1) }
       end
 
       context 'when there are skipped operations' do
-        let(:skipped) { [:operation_2] }
+        let(:skipped) { [:operation2] }
 
-        it { is_expected.to eq(operation_1: op_class_1) }
+        it { is_expected.to eq(operation1: op_class1) }
       end
     end
   end

spec/queries_preparer_spec.rb

@@ -11,16 +11,16 @@
     end
 
     let(:resource)  { 'User' }
-    let(:class_1)   { Class.new(GraphQL::Schema::Resolver) }
-    let(:class_2)   { GraphQL::Schema::Resolver }
+    let(:class1)    { Class.new(GraphQL::Schema::Resolver) }
+    let(:class2)    { GraphQL::Schema::Resolver }
     let(:auth_type) { GraphqlDevise::Types::AuthenticatableType }
-    let(:queries)   { { query_1: class_1, query_2: class_2 } }
+    let(:queries)   { { query1: class1, query2: class2 } }
 
     context 'when queries is *NOT* empty' do
       it 'assign gql attibutes to queries and changes keys using resource map' do
         result = subject
 
-        expect(result.keys).to contain_exactly(:user_query_1, :user_query_2)
+        expect(result.keys).to contain_exactly(:user_query1, :user_query2)
         expect(result.values.map(&:graphql_name)).to contain_exactly(
           'UserQuery1', 'UserQuery2'
         )