Skip to content

Commit 855261f

Browse files
author
David Revelo
committed
Address code review comments
1 parent 06d2f40 commit 855261f

5 files changed

Lines changed: 9 additions & 8 deletions

File tree

graphql_devise.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
3030
spec.add_dependency 'devise_token_auth', '>= 0.1.43', '< 2.0'
3131
spec.add_dependency 'graphql', '>= 1.8', '< 1.14.0'
3232
spec.add_dependency 'rails', '>= 4.2', '< 7.1'
33-
spec.add_dependency 'zeitwerk', '~> 2.2'
33+
spec.add_dependency 'zeitwerk'
3434

3535
spec.add_development_dependency 'appraisal'
3636
spec.add_development_dependency 'coveralls-ruby', '~> 0.2'

lib/graphql_devise.rb

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,25 +5,26 @@
55
require 'graphql'
66
require 'devise_token_auth'
77
require 'zeitwerk'
8-
require_relative '../app/models/graphql_devise/concerns/model'
9-
require_relative '../app/models/graphql_devise/concerns/additional_model_methods'
10-
require_relative 'graphql_devise/concerns/controller_methods'
118

129
GraphQL::Field.accepts_definitions(authenticate: GraphQL::Define.assign_metadata_key(:authenticate))
1310
GraphQL::Schema::Field.accepts_definition(:authenticate)
1411

1512
loader = Zeitwerk::Loader.for_gem
1613

17-
controller_methods_concern = "#{__dir__}/graphql_devise/concerns/controller_methods.rb"
18-
loader.ignore(controller_methods_concern)
14+
['additional_model_methods', 'controller_methods', 'model'].each do |concern_name|
15+
require_relative "graphql_devise/concerns/#{concern_name}"
16+
loader.ignore("#{__dir__}/graphql_devise/concerns/#{concern_name}.rb")
17+
end
18+
1919
loader.collapse("#{__dir__}/graphql_devise/errors")
2020
loader.collapse("#{__dir__}/generators")
21+
2122
loader.inflector.inflect('error_codes' => 'ERROR_CODES')
2223
loader.inflector.inflect('supported_options' => 'SUPPORTED_OPTIONS')
2324

2425
loader.setup
2526

26-
ActionDispatch::Routing::Mapper.send(:include, GraphqlDevise::RoutesMounter)
27+
ActionDispatch::Routing::Mapper.include(GraphqlDevise::RouteMounter)
2728

2829
module GraphqlDevise
2930
class Error < StandardError; end

app/models/graphql_devise/concerns/additional_model_methods.rb renamed to lib/graphql_devise/concerns/additional_model_methods.rb

File renamed without changes.
File renamed without changes.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module GraphqlDevise
2-
module RoutesMounter
2+
module RouteMounter
33
def mount_graphql_devise_for(resource, options = {})
44
clean_options = GraphqlDevise::ResourceLoader.new(resource, options, true).call(
55
GraphqlDevise::Types::QueryType,

0 commit comments

Comments
 (0)