Skip to content

Commit 6b8105c

Browse files
Merge pull request #87 from graphql-devise/explicit-require-schema-file
Add query and mutation type only once after app routes
2 parents 49d2f1b + 83a0a59 commit 6b8105c

4 files changed

Lines changed: 12 additions & 10 deletions

File tree

config/routes.rb

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
GraphqlDevise::Engine.routes.draw do
2+
if GraphqlDevise::Types::QueryType.fields.blank?
3+
GraphqlDevise::Types::QueryType.field(:dummy, resolver: GraphqlDevise::Resolvers::Dummy)
4+
end
5+
6+
if GraphqlDevise::Types::MutationType.fields.present?
7+
GraphqlDevise::Schema.mutation(GraphqlDevise::Types::MutationType)
8+
end
9+
10+
GraphqlDevise::Schema.query(GraphqlDevise::Types::QueryType)
11+
end

lib/graphql_devise.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ class InvalidMountOptionsError < GraphqlDevise::Error; end
99
end
1010

1111
require 'graphql_devise/concerns/controller_methods'
12+
require 'graphql_devise/schema'
1213
require 'graphql_devise/types/authenticatable_type'
1314
require 'graphql_devise/types/credential_type'
1415
require 'graphql_devise/types/mutation_type'

lib/graphql_devise/rails/routes.rb

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,6 @@ def mount_graphql_devise_for(resource, options = {})
5050
GraphqlDevise::Types::MutationType.field(action, mutation: mutation)
5151
end
5252

53-
if prepared_mutations.present? &&
54-
(Gem::Version.new(GraphQL::VERSION) < Gem::Version.new('1.10.0') || GraphqlDevise::Schema.mutation.nil?)
55-
GraphqlDevise::Schema.mutation(GraphqlDevise::Types::MutationType)
56-
end
57-
5853
prepared_queries = GraphqlDevise::MountMethod::OperationPreparer.new(
5954
resource: resource,
6055
custom: clean_options.operations,
@@ -69,10 +64,6 @@ def mount_graphql_devise_for(resource, options = {})
6964
GraphqlDevise::Types::QueryType.field(action, resolver: resolver)
7065
end
7166

72-
if prepared_queries.blank? && GraphqlDevise::Types::QueryType.fields.blank?
73-
GraphqlDevise::Types::QueryType.field(:dummy, resolver: GraphqlDevise::Resolvers::Dummy)
74-
end
75-
7667
Devise.mailer.helper(GraphqlDevise::MailerHelper)
7768

7869
devise_scope resource.underscore.tr('/', '_').to_sym do
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
module GraphqlDevise
22
class Schema < GraphQL::Schema
3-
query(GraphqlDevise::Types::QueryType)
43
end
54
end

0 commit comments

Comments
 (0)