Refactor sign up mutation

Author: David Revelo

app/graphql/graphql_devise/mutations/sign_up.rb

@@ -16,15 +16,14 @@ def resolve(confirm_success_url: nil, config_name: nil, **attrs)
           if resource.save
             yield resource if block_given?
 
-            if confirmable_enabled?(resource) && !resource.confirmed?
-              # user will require email authentication
+            if requires_confirmation?(resource)
               resource.send_confirmation_instructions(
                 client_config: config_name,
                 redirect_url:  confirm_success_url
               )
             end
 
-            set_auth_headers(resource) if active_for_authentication?(resource)
+            set_auth_headers(resource) if resource.active_for_authentication?
 
             { authenticable: resource }
           else
@@ -45,8 +44,8 @@ def confirmable_enabled?(resource)
         resource.respond_to?(:confirmed_at)
       end
 
-      def active_for_authentication?(resource)
-        resource.active_for_authentication?
+      def requires_confirmation?(resource)
+        resource.active_for_authentication? || !resource.confirmed?
       end
 
       def provider

spec/requests/mutations/sign_up_spec.rb

@@ -34,6 +34,7 @@
       )
 
       user = User.last
+
       expect(user).not_to be_active_for_authentication
       expect(user.confirmed_at).to be_nil
       expect(user.valid_password?(password)).to be_truthy