wip

Author: mcelicalderon

.rubocop.yml

@@ -59,7 +59,7 @@ Style/MethodCalledOnDoEndBlock:
   Enabled: false
 
 Naming/VariableNumber:
-  Enabled: false
+  EnforcedColonStyle: normalcase
 
 Style/StringLiterals:
   ConsistentQuotesInMultiline: true

lib/graphql_devise.rb

@@ -2,6 +2,12 @@
 require 'graphql'
 require 'devise_token_auth'
 
+module GraphqlDevise
+  class Error < StandardError; end
+
+  class InvalidMountOptionsError < GraphqlDevise::Error; end
+end
+
 require 'graphql_devise/concerns/controller_methods'
 require 'graphql_devise/types/authenticatable_type'
 require 'graphql_devise/types/credential_type'
@@ -17,11 +23,8 @@
 require 'graphql_devise/user_error'
 require 'graphql_devise/detailed_user_error'
 
+require 'graphql_devise/mount_method/options_validator'
 require 'graphql_devise/rails/queries_preparer'
 require 'graphql_devise/rails/mutations_preparer'
 require 'graphql_devise/rails/operation_checker'
 require 'graphql_devise/rails/operation_sanitizer'
-
-module GraphqlDevise
-  class Error < StandardError; end
-end

lib/graphql_devise/mount_method/option_validators/skip_only_validator.rb

@@ -0,0 +1,20 @@
+module GraphqlDevise
+  module MountMethod
+    module OptionValidators
+      class SkipOnlyValidator
+        def initialize(options: {})
+          @options = options
+        end
+
+        def validate!
+          if [@options[:skip], @options[:only]].all?(&:present?)
+            raise(
+              GraphqlDevise::InvalidMountOptionsError,
+              "Can't specify both `skip` and `only` options when mounting the route."
+            )
+          end
+        end
+      end
+    end
+  end
+end

lib/graphql_devise/mount_method/options_validator.rb

@@ -0,0 +1,15 @@
+require_relative 'option_validators/skip_only_validator'
+
+module GraphqlDevise
+  module MountMethod
+    class OptionsValidator
+      def initialize(validators = [])
+        @validators = validators
+      end
+
+      def validate!
+        @validators.each(&:validate!)
+      end
+    end
+  end
+end

lib/graphql_devise/rails/routes.rb

@@ -10,29 +10,30 @@ class Mapper
       :invitations
     ].freeze
 
-    def mount_graphql_devise_for(resource, opts = {})
-      custom_operations    = opts.fetch(:operations, {})
-      skipped_operations   = opts.fetch(:skip, [])
-      only_operations      = opts.fetch(:only, [])
-      additional_mutations = opts.fetch(:additional_mutations, {})
-      additional_queries   = opts.fetch(:additional_queries, {})
-      path                 = opts.fetch(:at, '/graphql_auth')
+    def mount_graphql_devise_for(resource, options = {})
+      custom_operations    = options.fetch(:operations, {})
+      skipped_operations   = options.fetch(:skip, [])
+      only_operations      = options.fetch(:only, [])
+      additional_mutations = options.fetch(:additional_mutations, {})
+      additional_queries   = options.fetch(:additional_queries, {})
+      path                 = options.fetch(:at, '/graphql_auth')
       mapping_name         = resource.underscore.tr('/', '_').to_sym
-      authenticatable_type = opts[:authenticatable_type].presence ||
-        "Types::#{resource}Type".safe_constantize ||
-        GraphqlDevise::Types::AuthenticatableType
+      authenticatable_type = options[:authenticatable_type].presence ||
+                             "Types::#{resource}Type".safe_constantize ||
+                             GraphqlDevise::Types::AuthenticatableType
+
+      GraphqlDevise::MountMethod::OptionsValidator.new(
+        [
+          GraphqlDevise::MountMethod::OptionValidators::SkipOnlyValidator.new(options: options)
+        ]
+      ).validate!
+
       param_operations     = {
         custom:  custom_operations,
         only:    only_operations,
         skipped: skipped_operations
       }
 
-      GraphqlDevise::OperationChecker.call(
-        mutations: GraphqlDevise::DefaultOperations::MUTATIONS,
-        queries:   GraphqlDevise::DefaultOperations::QUERIES,
-        **param_operations
-      )
-
       devise_for(
         resource.pluralize.underscore.tr('/', '_').to_sym,
         module:     :devise,
@@ -61,7 +62,7 @@ def mount_graphql_devise_for(resource, opts = {})
       end
 
       if (prepared_mutations.present? || additional_mutations.present?) &&
-          (Gem::Version.new(GraphQL::VERSION) <= Gem::Version.new('1.10.0') || GraphqlDevise::Schema.mutation.nil?)
+         (Gem::Version.new(GraphQL::VERSION) <= Gem::Version.new('1.10.0') || GraphqlDevise::Schema.mutation.nil?)
         GraphqlDevise::Schema.mutation(GraphqlDevise::Types::MutationType)
       end
 

spec/services/mount_method/option_validators/skip_only_validator_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+RSpec.describe GraphqlDevise::MountMethod::OptionValidators::SkipOnlyValidator do
+  describe '#validate!' do
+    subject { -> { described_class.new(options: options).validate! } }
+
+    context 'when only `only` key is set' do
+      let(:options) { { only: 'Irrelevant value' } }
+
+      it { is_expected.not_to raise_error }
+    end
+
+    context 'when only `skip` key is set' do
+      let(:options) { { skip: 'Irrelevant value' } }
+
+      it { is_expected.not_to raise_error }
+    end
+
+    context 'when `skip` and `only` keys are set' do
+      let(:options) { { only: 'Irrelevant value', skip: 'irrelevant for specs' } }
+
+      it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, "Can't specify both `skip` and `only` options when mounting the route.") }
+    end
+
+    context 'when neither `skip` nor `only are set`' do
+      let(:options) { { irrelevant_option: 'Irrelevant value', another_option: 'irrelevant for specs' } }
+
+      it { is_expected.not_to raise_error }
+    end
+  end
+end

spec/services/mount_method/options_validator_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+RSpec.describe GraphqlDevise::MountMethod::OptionsValidator do
+  describe '#validate!' do
+    subject { -> { described_class.new([validator1, validator2]).validate! } }
+
+    let(:validator1) { double(:validator1, 'validate!': nil) }
+    let(:validator2) { double(:validator2, 'validate!': nil) }
+
+    context 'when first validator fails' do
+      before { allow(validator1).to receive(:validate!).and_raise(GraphqlDevise::InvalidMountOptionsError, 'validator1 error') }
+
+      context 'when second validator fails' do
+        before { allow(validator2).to receive(:validate!).and_raise(GraphqlDevise::InvalidMountOptionsError, 'validator2 error') }
+
+        it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, 'validator1 error') }
+      end
+
+      context 'when second validator does not fail' do
+        it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, 'validator1 error') }
+      end
+    end
+
+    context 'when first validator does not fail' do
+      context 'when second validator fails' do
+        before { allow(validator2).to receive(:validate!).and_raise(GraphqlDevise::InvalidMountOptionsError, 'validator2 error') }
+
+        it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, 'validator2 error') }
+      end
+
+      context 'when second validator does not fail' do
+        it { is_expected.not_to raise_error }
+      end
+    end
+  end
+end