Fix Maven metadata copy across reactor modules (#1020)

* Fix Maven metadata copy across reactor modules

* Fix grund cross-reference formatting

Author: jvukicev

docs/src/docs/asciidoc/changelog.adoc

@@ -13,6 +13,7 @@
 
 == Release 1.1.6
 
+- Fix Maven `native:metadata-copy` replacement when sequential reactor modules share an output directory, including failure-safe staging and removal of stale metadata types.
 - Maven native test goals now read the matching Surefire or Failsafe execution, including its configured `testClassesDirectory`, and keep their test-ID output separate.
 - Clarify the separate Gradle launcher, JDK 17 compilation toolchain, and GraalVM prerequisites; add a docs-independent core build mode while keeping the default full build responsible for included-build assembly, verification, and documentation rendering.
 

native-maven-plugin/docs/e2e.md

@@ -73,6 +73,14 @@ This protects [§FS-resources-and-metadata.2](functional/resources-and-metadata.
 disabled stages, merge behavior, and `native:metadata-copy`. This protects [§FS-tracing-agent](functional/tracing-agent.md#fs-tracing-agent-maven-goals-attach-and-post-process-native-image-tracing-agent-metadata) and
 [§common/FS-common-libraries.3](../../common/docs/functional-spec.md#3-native-image-tracing-agent).
 
+#### 3.6.1 Shared reactor destination
+
+`issues/MetadataCopyReactorFunctionalTest` with `reproducers/issue-650` verifies deterministic
+replacement and merge behavior when sequential reactor modules share one metadata destination. It
+also verifies that replacement removes metadata types absent from the later module and that a failed
+`native-image-configure` invocation leaves the destination unchanged without staging output. This
+protects [§FS-tracing-agent.4.1](functional/tracing-agent.md#41-shared-destination-replacement).
+
 ### 3.7 Maven integration
 
 `SBOMFunctionalTest`, `JavaApplicationWithTestsFunctionalTest`, `issues/JavaAppWithTestsAndParentPomFunctionalTest`

native-maven-plugin/docs/functional/tracing-agent.md

@@ -46,6 +46,19 @@ configurations and must remove the filter and its directory when the Maven sessi
 `native:metadata-copy` must copy or merge selected agent stages into the configured output
 directory and honor disabled main/test stages.
 
+### 4.1 Shared destination replacement
+
+When sequential metadata-copy invocations share an output directory, `merge=false` must ignore
+existing destination metadata and replace every Native Image metadata entry owned by the goal with
+the current module's selected stages, while `merge=true` must include the existing destination as
+an input and replace it with the combined result. The goal must generate into staging and update the
+configured destination only after `native-image-configure` succeeds. If post-processing fails, the
+configured destination must remain unchanged and the staging output must be removed. This preserves
+the replacement and merge modes in
+[§root/FS-tracing-agent.4](../../../docs/spec/functional/tracing-agent.md#4-merge-and-copy) and the
+existing Maven parameter meanings required by
+[§root/REQ-backwards-compatibility.2](../../../docs/spec/requirements.md#2-configuration-compatibility).
+
 ## 5. Agent example
 
 Agent collection is enabled through `<agent>` configuration or `-Dagent=true`; post-processing is

native-maven-plugin/reproducers/issue-650/README.md

@@ -0,0 +1,17 @@
+# Issue 650 reactor fixture metadata
+
+The JSON files cannot contain comments, so this adjacent manifest grounds each metadata fixture used
+by the shared-reactor-destination scenario:
+
+- `first-module/fixture-target/native/agent-output/test/jni-config.json` — [§E2E-functional-tests.3.6.1](../../docs/e2e.md#361-shared-reactor-destination)
+- `first-module/fixture-target/native/agent-output/test/predefined-classes-config.json` — [§E2E-functional-tests.3.6.1](../../docs/e2e.md#361-shared-reactor-destination)
+- `first-module/fixture-target/native/agent-output/test/proxy-config.json` — [§E2E-functional-tests.3.6.1](../../docs/e2e.md#361-shared-reactor-destination)
+- `first-module/fixture-target/native/agent-output/test/reflect-config.json` — [§E2E-functional-tests.3.6.1](../../docs/e2e.md#361-shared-reactor-destination)
+- `first-module/fixture-target/native/agent-output/test/resource-config.json` — [§E2E-functional-tests.3.6.1](../../docs/e2e.md#361-shared-reactor-destination)
+- `first-module/fixture-target/native/agent-output/test/serialization-config.json` — [§E2E-functional-tests.3.6.1](../../docs/e2e.md#361-shared-reactor-destination)
+- `second-module/fixture-target/native/agent-output/test/jni-config.json` — [§E2E-functional-tests.3.6.1](../../docs/e2e.md#361-shared-reactor-destination)
+- `second-module/fixture-target/native/agent-output/test/predefined-classes-config.json` — [§E2E-functional-tests.3.6.1](../../docs/e2e.md#361-shared-reactor-destination)
+- `second-module/fixture-target/native/agent-output/test/proxy-config.json` — [§E2E-functional-tests.3.6.1](../../docs/e2e.md#361-shared-reactor-destination)
+- `second-module/fixture-target/native/agent-output/test/reflect-config.json` — [§E2E-functional-tests.3.6.1](../../docs/e2e.md#361-shared-reactor-destination)
+- `second-module/fixture-target/native/agent-output/test/resource-config.json` — [§E2E-functional-tests.3.6.1](../../docs/e2e.md#361-shared-reactor-destination)
+- `second-module/fixture-target/native/agent-output/test/serialization-config.json` — [§E2E-functional-tests.3.6.1](../../docs/e2e.md#361-shared-reactor-destination)

native-maven-plugin/reproducers/issue-650/first-module/fixture-target/native/agent-output/test/jni-config.json

@@ -0,0 +1 @@
+[]

native-maven-plugin/reproducers/issue-650/first-module/fixture-target/native/agent-output/test/predefined-classes-config.json

@@ -0,0 +1 @@
+[]

native-maven-plugin/reproducers/issue-650/first-module/fixture-target/native/agent-output/test/proxy-config.json

@@ -0,0 +1 @@
+[]

native-maven-plugin/reproducers/issue-650/first-module/fixture-target/native/agent-output/test/reflect-config.json

@@ -0,0 +1,3 @@
+[
+  {"name":"issue650.FirstModuleMarker"}
+]

native-maven-plugin/reproducers/issue-650/first-module/fixture-target/native/agent-output/test/resource-config.json

@@ -0,0 +1 @@
+{"resources":{"includes":[]}}

native-maven-plugin/reproducers/issue-650/first-module/fixture-target/native/agent-output/test/serialization-config.json

@@ -0,0 +1 @@
+[]