Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

Commit de1a639

Browse files
resolve comments
1 parent 439dcf2 commit de1a639

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

src/main/java/com/google/api/generator/gapic/composer/common/AbstractServiceStubSettingsClassComposer.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,6 @@ public abstract class AbstractServiceStubSettingsClassComposer implements ClassC
137137

138138
private static final String DOT = ".";
139139

140-
protected static final TypeStore FIXED_TYPESTORE = createStaticTypes();
141-
142-
protected static final VariableExpr DEFAULT_SERVICE_SCOPES_VAR_EXPR =
143-
createDefaultServiceScopesVarExpr();
144140
private static final VariableExpr NESTED_UNARY_METHOD_SETTINGS_BUILDERS_VAR_EXPR =
145141
createNestedUnaryMethodSettingsBuildersVarExpr();
146142
private static final VariableExpr NESTED_RETRYABLE_CODE_DEFINITIONS_VAR_EXPR =
@@ -150,6 +146,11 @@ public abstract class AbstractServiceStubSettingsClassComposer implements ClassC
150146

151147
private final TransportContext transportContext;
152148

149+
protected static final TypeStore FIXED_TYPESTORE = createStaticTypes();
150+
151+
protected static final VariableExpr DEFAULT_SERVICE_SCOPES_VAR_EXPR =
152+
createDefaultServiceScopesVarExpr();
153+
153154
protected AbstractServiceStubSettingsClassComposer(TransportContext transportContext) {
154155
this.transportContext = transportContext;
155156
}

src/main/java/com/google/api/generator/gapic/composer/grpc/ServiceStubSettingsClassComposer.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,9 @@ protected MethodDefinition createDefaultCredentialsProviderBuilderMethod() {
113113
.setArguments(DEFAULT_SERVICE_SCOPES_VAR_EXPR)
114114
.setReturnType(returnType)
115115
.build();
116+
117+
// This section is specific to GAPIC clients. It sets UseJwtAccessWithScope value to true to
118+
// enable self signed JWT feature.
116119
credsProviderBuilderExpr =
117120
MethodInvocationExpr.builder()
118121
.setExprReferenceExpr(credsProviderBuilderExpr)
@@ -122,6 +125,7 @@ protected MethodDefinition createDefaultCredentialsProviderBuilderMethod() {
122125
PrimitiveValue.builder().setType(TypeNode.BOOLEAN).setValue("true").build()))
123126
.setReturnType(returnType)
124127
.build();
128+
125129
return MethodDefinition.builder()
126130
.setHeaderCommentStatements(
127131
SettingsCommentComposer.DEFAULT_CREDENTIALS_PROVIDER_BUILDER_METHOD_COMMENT)

0 commit comments

Comments
 (0)