Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

Commit a40285b

Browse files
authored
[ggj][ast][engx] fix: validate non-null elements for WhileStatement (#469)
* fix: swap assertEquals args in JavaWriterVisitorTest to match (expected, actusl) order * fix: swap assertEquals args in ImportWriterVisitorTest to match (expected, actusl) order * fix: add node validator to refactor/centralize null element checks * fix: validate non-null elements for IfStatement * fix: validate non-null elements for AnonymousClassExpr * fix: validate non-null elements for BlockStatement * fix: validate non-null elements for ClassDefinition * fix: validate non-null elements for ConcreteReference * fix: validate non-null elements for ForStatement * fix: validate non-null elements for GeneralForStatement * fix: validate non-null elements for MethodDefinition * fix: validate non-null elements for PackageInfoDefinition * fix: validate non-null elements for SynchronizedStatement * fix: validate non-null elements for TryCatchStatement * fix: validate non-null elements for VaporReference * fix: validate non-null elements for VariableExpr * fix: validate non-null elements for WhileStatement
1 parent 8906223 commit a40285b

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

src/main/java/com/google/api/generator/engine/ast/WhileStatement.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,14 @@ public abstract static class Builder {
4141

4242
public abstract Builder setBody(List<Statement> body);
4343

44+
// Private.
45+
abstract ImmutableList<Statement> body();
46+
4447
abstract WhileStatement autoBuild();
4548

4649
public WhileStatement build() {
4750
WhileStatement whileStatement = autoBuild();
51+
NodeValidator.checkNoNullElements(body(), "body", "while statement");
4852
Preconditions.checkState(
4953
whileStatement.conditionExpr().type().equals(TypeNode.BOOLEAN),
5054
"While condition must be a boolean-typed expression");

0 commit comments

Comments
 (0)