Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Commit f979d31

Browse files
committed
Revert "splitting tests"
This reverts commit ae49fde.
1 parent b7ff8fc commit f979d31

4 files changed

Lines changed: 6 additions & 25 deletions

File tree

.kokoro/build.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ fi
5555

5656
# If NOX_SESSION is set, it only runs the specified session,
5757
# otherwise run all the sessions.
58-
if [[ -n "${SPANNER_DATABASE_DIALECT:-}" ]]; then
59-
export SPANNER_DATABASE_DIALECT = ${SPANNER_DATABASE_DIALECT:-}
6058
if [[ -n "${NOX_SESSION:-}" ]]; then
6159
python3 -m nox -s ${NOX_SESSION:-}
6260
else

.kokoro/presubmit/system-3.8-google-standard-sql.cfg

Lines changed: 0 additions & 13 deletions
This file was deleted.
Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,4 @@
44
env_vars: {
55
key: "NOX_SESSION"
66
value: "system-3.8"
7-
}
8-
9-
# Run for postgres
10-
env_vars: {
11-
key: "SPANNER_DATABASE_DIALECT"
12-
value: "POSTGRESQL"
137
}

noxfile.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -238,17 +238,15 @@ def install_systemtest_dependencies(session, *constraints):
238238

239239

240240
@nox.session(python=SYSTEM_TEST_PYTHON_VERSIONS)
241-
def system(session):
241+
@nox.parametrize("database_dialect", ["GOOGLE_STANDARD_SQL", "POSTGRESQL"])
242+
def system(session, database_dialect):
242243
"""Run the system test suite."""
243244
constraints_path = str(
244245
CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt"
245246
)
246247
system_test_path = os.path.join("tests", "system.py")
247248
system_test_folder_path = os.path.join("tests", "system")
248249

249-
# If POSTGRESQL tests and Emulator, skip the tests
250-
if os.environ.get("SPANNER_EMULATOR_HOST") and os.environ.get("SPANNER_DATABASE_DIALECT") == "POSTGRESQL":
251-
session.skip("Postgresql is not supported by Emulator yet.")
252250
# Check the value of `RUN_SYSTEM_TESTS` env var. It defaults to true.
253251
if os.environ.get("RUN_SYSTEM_TESTS", "true") == "false":
254252
session.skip("RUN_SYSTEM_TESTS is set to false, skipping")
@@ -272,6 +270,10 @@ def system(session):
272270

273271
install_systemtest_dependencies(session, "-c", constraints_path)
274272

273+
# If POSTGRESQL tests and Emulator, skip the tests
274+
if os.environ.get("SPANNER_EMULATOR_HOST") and database_dialect == "POSTGRESQL":
275+
session.skip("Postgresql is not supported by Emulator yet.")
276+
275277
# Run py.test against the system tests.
276278
if system_test_exists:
277279
session.run(

0 commit comments

Comments
 (0)