Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

fix: remove pytz#707

Merged
chrisrossi merged 5 commits into
masterfrom
remove-pytz
Aug 12, 2021
Merged

fix: remove pytz#707
chrisrossi merged 5 commits into
masterfrom
remove-pytz

Conversation

@busunkim96

@busunkim96 busunkim96 commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

@busunkim96 busunkim96 requested a review from andrewsg as a code owner August 12, 2021 20:21
@busunkim96 busunkim96 requested review from a team August 12, 2021 20:21
@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/python-ndb API. label Aug 12, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@chrisrossi

Copy link
Copy Markdown
Contributor

This appears to be a whitespace-only change.

@chrisrossi

Copy link
Copy Markdown
Contributor

This appears to be a whitespace-only change.

Nevermind, was accidentally looking at diff for single commit

@chrisrossi

Copy link
Copy Markdown
Contributor

Unfortunately, NDB is still required to support Python 2.7, where datetime.timezone.utc is not present. If I understand the problem to be addressed properly, we probably just need to add the pytz dependency to setup.py instead.

@busunkim96

Copy link
Copy Markdown
Contributor Author

@chrisrossi Ah makes sense. I backed out the original changes and just added pytz to the setup.py.

@chrisrossi chrisrossi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants