Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

docs(samples): updated var name to avoid shadowing built-in - #238

Merged
Sita04 merged 1 commit into
mainfrom
patch-sample-varname
Feb 16, 2022
Merged

docs(samples): updated var name to avoid shadowing built-in#238
Sita04 merged 1 commit into
mainfrom
patch-sample-varname

Conversation

@Sita04

@Sita04 Sita04 commented Feb 15, 2022

Copy link
Copy Markdown
Contributor

Updated variable name "id" to "key_id" as it shadows python built-in.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

b/206514162

@product-auto-label product-auto-label Bot added api: cloudkms Issues related to the googleapis/python-kms API. samples Issues that are directly related to samples. labels Feb 15, 2022
@Sita04
Sita04 requested a review from busunkim96 February 15, 2022 19:42
@Sita04
Sita04 merged commit 5bbf2c3 into main Feb 16, 2022
@Sita04
Sita04 deleted the patch-sample-varname branch February 16, 2022 05:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: cloudkms Issues related to the googleapis/python-kms API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants