feat: add type hint for public methods#445
Conversation
google-cla
Bot
added
the
cla: yes
product-auto-label
Bot
added
the
api: bigquery
| google/cloud/bigquery_v2/ | ||
| output = .pytype/ | ||
| # Workaround for https://github.com/google/pytype/issues/150 | ||
| disable = pyi-error No newline at end of file |
There was a problem hiding this comment.
This file is synthtool generated so changes are not allowed here, but for the reference and pass current tests changed the current file.
There was a problem hiding this comment.
google/pytype#150 is marked as closed. Can you provide a little more context as to why this is needed?
HemangChothani
requested review from
busunkim96
and removed request for
a team
HemangChothani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Looking good, thanks! A few questions.
| from google.cloud.bigquery.table import TableReference | ||
| from google.cloud.bigquery.table import RowIterator | ||
|
|
||
| # Types needed only for Type Hints |
There was a problem hiding this comment.
I don't see any reason to keep these in a separate location from the other imports. Let's put them in their respective groups.
| max_creation_time=None, | ||
| ): | ||
| project: str = None, | ||
| parent_job: Union[_AsyncJob, str] = None, |
There was a problem hiding this comment.
parent_job is only relevant for queries, so I think we can put QueryJob here and avoid the use of a private type.
| table: Union[Table, TableReference, str], | ||
| rows: Union[Sequence[Tuple], Sequence[Dict]], | ||
| selected_fields: Sequence[SchemaField] = None, | ||
| **kwargs: dict, |
There was a problem hiding this comment.
Why dict here and Dict below?
| permissions: Sequence[str], | ||
| retry: retries.Retry = DEFAULT_RETRY, | ||
| timeout: float = None, | ||
| ): |
There was a problem hiding this comment.
Looking at the system tests, I believe the output for this method id Dict
python-bigquery/tests/system.py
Line 1645 in dbc68b3
|
Bump, just checking the status of this? Generally speaking, though, type hints would be welcome, even though static type checks have not been added to Kokoro (yet). |
|
Superseded by #613. (will also address the comments there) |
4 participants
Fixes #157