Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Commit 0207e1d

Browse files
committed
Small doc update and remove obsolete TODOs
Change-Id: Ie08217d025df3ec3c97dc96268f1c4e1d20b33bf
1 parent 8e090fc commit 0207e1d

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/AbstractProtoStructReader.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,6 @@ private void checkNonNullOfType(
316316

317317
private void checkNonNullOfType(
318318
int columnIndex, SqlType<?> expectedType, SqlType<?> actualType, Object columnNameForError) {
319-
// TODO check on toString formatting
320319
Preconditions.checkState(
321320
SqlType.typesMatch(expectedType, actualType),
322321
"Column %s is not of correct type: expected %s but was %s",

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@
9999
import com.google.cloud.bigtable.data.v2.models.RowMutationEntry;
100100
import com.google.cloud.bigtable.data.v2.models.SampleRowKeysRequest;
101101
import com.google.cloud.bigtable.data.v2.models.TargetId;
102+
import com.google.cloud.bigtable.data.v2.models.sql.Statement;
102103
import com.google.cloud.bigtable.data.v2.stub.changestream.ChangeStreamRecordMergingCallable;
103104
import com.google.cloud.bigtable.data.v2.stub.changestream.GenerateInitialChangeStreamPartitionsUserCallable;
104105
import com.google.cloud.bigtable.data.v2.stub.changestream.ReadChangeStreamResumptionStrategy;
@@ -1300,8 +1301,8 @@ public Map<String, String> extract(
13001301
* Creates a callable chain to handle streaming ExecuteQuery RPCs. The chain will:
13011302
*
13021303
* <ul>
1303-
* <li>Convert a {@link ExecuteQueryRequest} into a {@link ExecuteQueryCallContext}, which
1304-
* passes the {@link ExecuteQueryRequest} & a future for the {@link
1304+
* <li>Convert a {@link Statement} into a {@link ExecuteQueryCallContext}, which passes the
1305+
* {@link Statement} & a future for the {@link
13051306
* com.google.cloud.bigtable.data.v2.models.sql.ResultSetMetadata} up the call chain.
13061307
* <li>Upon receiving the response stream, it will set the metadata future and translate the
13071308
* {@link com.google.bigtable.v2.PartialResultSet}s into {@link SqlRow}s
@@ -1310,7 +1311,6 @@ public Map<String, String> extract(
13101311
* com.google.cloud.bigtable.data.v2.stub.sql.SqlServerStream}
13111312
* </ul>
13121313
*/
1313-
// TODO update docs for Statement
13141314
@InternalApi("For internal use only")
13151315
public ExecuteQueryCallable createExecuteQueryCallable() {
13161316
// TODO support resumption

0 commit comments

Comments
 (0)