-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Decouple Transaction from Connection #514
Copy link
Copy link
Closed
Labels
api: datastoreIssues related to the Datastore API.Issues related to the Datastore API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Metadata
Metadata
Assignees
Labels
api: datastoreIssues related to the Datastore API.Issues related to the Datastore API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Type
Fields
Give feedbackNo fields configured for issues without a type.
After #509 is in,We need to decoupleTransactionfromConnectionand allowTransactionto inherit fromBatch.Things to be done
Transactionto inherit fromBatch(Derive 'Transaction' from 'Batch'. #516)Key.get()with top-leveldatastore.get()(Rename get_entities() to get(). #520, Allow get() to take a single key (in addition to a list) #521, Remove Key.get() and Entity.reload() #522)Entity.save()with top-leveldatastore.put()(#514: adddatastore.putAPI, remove `Entity.save' #548)Key.delete()witg top-leveldatastore.delete()(Remove Key.get() and Entity.reload() #522)save_entity()anddelete_entities()fromConnection(#514: rip outConnectioncruft #550)Connection.mutation(). (#514: rip outConnectioncruft #550)Connection.transaction()(#514: rip outConnectioncruft #550)Also relevant: #447 (
TransactionandBatchshould not have adataset_iduntil they have objects to work with)For reference, RPC methods are: